All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/3] perf build: Build the Python extension before pylint consumers
Date: Wed, 30 Sep 2026 12:12:10 +0100	[thread overview]
Message-ID: <20260930111210.GJ14479@e132581.arm.com> (raw)
In-Reply-To: <20260930091525.B98E41F000FF@smtp.kernel.org>

On Wed, Sep 30, 2026 at 09:15:25AM +0000, sashiko-bot@kernel.org wrote:

[...]

> > +ifdef PYLINT
> > +# Build the Python extension before starting sub-makes that lint its users.
> > +$(PERF_IN) $(LIBPERF_TEST_IN): | $(LANG_BINDINGS)
> 
> [Severity: Low]
> Does this order-only dependency block the $(PERF_IN) sub-make from executing
> until $(LANG_BINDINGS) and all its prerequisites (including $(LIBPERF_UTIL))
> are fully built?
> 
> $(PERF_IN) launches the sub-make that compiles all builtin-*.c files.
> Meanwhile, $(LANG_BINDINGS) depends on $(PERFLIBS_PY), which launches the
> sub-make that compiles all util/*.c files.
> 
> Does this completely serialize the compilation of the builtin/ directory
> behind the full compilation of the util/ directory and the Python extension,
> impacting concurrent parallel build efficiency?


> Furthermore, does it force an isolated make perf to needlessly build the
> Python extension when PYLINT is enabled on the host?

Fair point. I will update the Makefile to separate pylint from C
compilation, this can avoid dependency within C files, and can avoid
the dependency between perf binary and python extension.

  reply	other threads:[~2026-09-30 11:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  9:01 [PATCH 0/3] perf build: Fix pylint build failures Leo Yan
2026-09-30  9:01 ` [PATCH 1/3] perf build: Build the Python extension before pylint consumers Leo Yan
2026-09-30  9:15   ` sashiko-bot
2026-09-30 11:12     ` Leo Yan [this message]
2026-09-30  9:01 ` [PATCH 2/3] perf build: Add the output Python directory to pylint's PYTHONPATH Leo Yan
2026-09-30  9:07   ` sashiko-bot
2026-09-30  9:01 ` [PATCH 3/3] perf test: Suppress optparse deprecation warning with older pylint Leo Yan
2026-09-30  9:04   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930111210.GJ14479@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.