Re: [PATCH mlx5-next V2 07/10] RDMA/mlx5: Extract IB specific lock out of data direct

[sashiko-bot@kernel.org]

> From: Dragos Tatulea <dtatulea@nvidia.com>
> 
> The data_direct_lock from struct mlx5_ib_dev is an IB specific lock.
> It protects from unbind while mlx5_data_direct_dev is being accessed.
> 
> So move data_direct_lock out of the generic bind/unbind functions
> and into the IB specific notifier callback.
> 
> data_direct_dev can be set during bind/unbind with a simple WRITE_ONCE,
> the lock is no longer needed.
> 
> Each user of the data direct registration API has to do their own
> locking if necessary.
> 
> During unbind, the data_direct_dev is set to NULL before calling the
> notifiers to avoid multiple users still accessing the data_direct_dev
> while unbind is in progress. This is to avoid another data
> direct specific lock which can lead to lock ordering issues.
> 
> This patch has no functional changes.
> 
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930114227.139274-1-tariqt@nvidia.com?part=7