Re: [PATCH v4 9/9] arm64: dts: renesas: Add LVDS overlay for RZ/G3L SMARC EVK with ITE6263

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dts: unused Device Tree binding includes in the overlay
- [Low] build: missing &du and &lvds nodes in base DT break fdtoverlay
--

commit a9bfeabadeefbed460cdf1bc271c6ea8bca9412f
Author: Biju Das <biju.das.jz@bp.renesas.com>

arm64: dts: renesas: Add LVDS overlay for RZ/G3L SMARC EVK with ITE6263

Add a Device Tree overlay (r9a08g046l48-smarc-lvds-ite6263.dtso) for the
RZ/G3L (R9A08G046) SMARC EVK board to support LVDS-to-HDMI output via the
ITE 6263 HDMI transmitter.

> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index 8c6a448907151..3cecc40204e90 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -190,6 +190,9 @@ dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc.dtb
>  dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-dsi-adv7535.dtbo
>  r9a08g046l48-smarc-dsi-adv7535-dtbs := r9a08g046l48-smarc.dtb r9a08g046l48-smarc-dsi-adv7535.dtbo
>  dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-dsi-adv7535.dtb
> +dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-lvds-ite6263.dtbo
> +r9a08g046l48-smarc-lvds-ite6263-dtbs := r9a08g046l48-smarc.dtb r9a08g046l48-smarc-lvds-ite6263.dtbo

[Severity: Low]
Will this composite build target fail when fdtoverlay runs?

The base SoC device tree (r9a08g046l48-smarc.dtb) appears to lack any nodes
for the display controller or LVDS interface. When fdtoverlay attempts to
resolve the __fixups__ for the &du and &lvds nodes against the base DTB's
__symbols__, it will fail with an FDT_ERR_NOTFOUND error and break make dtbs.

[ ... ]
> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-lvds-ite6263.dtso b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-lvds-ite6263.dtso
> new file mode 100644
> index 0000000000000..3c64db8d22e9e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-lvds-ite6263.dtso
> @@ -0,0 +1,86 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Device Tree overlay for the RZ/G3L SMARC EVK with ITE6263
> + * connected to LVDS and LCDC enabled.
> + *
> + * Copyright (C) 2026 Renesas Electronics Corp.
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/pinctrl/renesas,r9a08g046-pinctrl.h>

[Severity: Low]
Are these includes necessary?

There don't appear to be any GPIO properties, interrupts, or pinctrl nodes
defined or referenced in this overlay file, so these directives could be
safely dropped.

[ ... ]
> +&du {
> +	status = "okay";
> +};

[Severity: Low]
Does the &du label exist in the base r9a08g046l48-smarc.dtb?

If it's missing, fdtoverlay won't be able to resolve the symbol and will
fail.

[ ... ]
> +&lvds {
> +	status = "okay";
> +
> +	ports {

[Severity: Low]
Does the &lvds label exist in the base r9a08g046l48-smarc.dtb?

Similar to the &du node, if this label is not present in the base tree,
fdtoverlay will fail during the build.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930133257.23210-1-biju.das.jz@bp.renesas.com?part=9