From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F0850B435 for ; Wed, 30 Sep 2026 14:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790780285; cv=none; b=i1LDofRDek5OIRvEWdwrNxL1pBLQrYOuowlXqT8TQIY5Zmiyq2X2KF3Pa28etOCbKKy75ltVlLKly7QHPTq2a9nJc+TIiknS8HnB0Zn9PMcFRP1JITK9tohdnLJEo1bJiuwjGsA4/9KOgCKNzPPBZ/be11iUXMRXZ7LB18Ansu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790780285; c=relaxed/simple; bh=RfK7Kl8yVQyl/4+jZpsCjQXHuIi7h12rihRMoqkRN3I=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=FMlYFi9vgQxwo7Py+8tOpjusqMPccDz0VW35KU0KsFeROCJTSwWw6W+89XX/4fZnAxWUqD7U3n0ztCV4U6Fi6lVdBFel9mAfPI/b2xfq9MFb8MHMT7w4S6Pfj0/hWSOSFdZmD3SZqOQgMgh+kEIYB0oNo0uzP/1fSqPjDtcsjas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eTT8rSES; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eTT8rSES" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56F4A1F00898; Wed, 30 Sep 2026 14:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790780273; bh=zeczajftE7m4hge0KmE3dUIK4JSk8WdnAPf0ngXwdNM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eTT8rSESlkwe6pl12uTYzZueZAphGZA9WW+fLTgGSIL8ZlVWzKIbZVUSILQ3dz08m lZBUf7f0qXSVISPqWq7Ty5+TNlvjolEAH9J09dUdRVP83tVXaxgJ4ny+W725TLhRwX V6CmG2eISJII9d6UHU5iUOOvbyQOjKYNgxEw4LkOF9+97FWE8Kv2sCOZxp/E1Y8a9q Xc3wnLswRxs3na9xjfh8p++VcFNyNErtPPPqZzVrZHVXvLFVt63akhco9o2SAXzISd cI7WIQ/PCtWk0q+s+bEsOcDKwJkHARCBqpilz62/dthJVnjV6OgdK7AYq+KjHnUogU 9EyRrGyWqazsg== From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH 2/4] PCI: Match the hierarchy's MPS to a device's MPSS as necessary Reply-To: sashiko-reviews@lists.linux.dev To: "Niklas Cassel" Cc: linux-pci@vger.kernel.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260930145017.1356088-8-cassel@kernel.org> References: <20260930145017.1356088-6-cassel@kernel.org> <20260930145017.1356088-8-cassel@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Sep 2026 14:57:53 +0000 Message-Id: <20260930145753.56F4A1F00898@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > From: Hans Zhang <18255117159@163.com> >=20 > pci_configure_mps() enumerates top-down and programs each device's Maximum > Payload Size (MPS) to match its upstream bridge. When a device's MPS > Supported (MPSS) is too small to match, commit 9f0e89359775 ("PCI: Match > Root Port's MPS to endpoint's MPSS as necessary") reduces the upstream > bridge instead, but only when that bridge is a Root Port. >=20 > That covers an endpoint directly below a Root Port and nothing else. With > a Switch in between, the Switch ports have already inherited the Root > Port's larger MPS, the reduction is skipped because the upstream bridge is > a Switch Downstream Port, and pcie_set_mps() then fails with -EINVAL for > the endpoint. The endpoint is left below a port programmed for a larger > MPS, so any larger TLP it receives is treated as Malformed. >=20 > [ ... ] > Fixes: 9f0e89359775 ("PCI: Match Root Port's MPS to endpoint's MPSS as ne= cessary") > Signed-off-by: Hans Zhang <18255117159@163.com> > Assisted-by: LLM > Co-developed-by: Niklas Cassel > Signed-off-by: Niklas Cassel Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260930145017.1356= 088-6-cassel@kernel.org?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FCA7CA5FC5 for ; Wed, 30 Sep 2026 14:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DPlnUsq60U8QF43zprkN6RXt2Cw8jmNZzkSG+iZGgFw=; b=AF+EgILZ7N3lxr zO+uCYkvdd3cq+3BDHnxe5qBSM0482/mEcL2fcbHUarqzzHiOdetUAr0Ce2+M90ZD1oKRcKtxHuXN ByMe66yYWXO1rUziZ9/GNjh4q92ELj+ElRLwCXmyE6FeU920XU47bUpMmrwtQ23+Ireui4Pu3+dNq eLTp1j0ckA47HlpC0ZO/ntvqU+3ufdmymNYPdPo+QYzQFlKiu86A8I0ORCJPT5om34fVWARXrXSm3 ChOwaSIrSZJpU/ANl2oCR5JDXKB+lWpSPDZTIyR6oDIzbIrtKaDwgptpXQWx1MaiyolR6wtz5q8gF f+FEMskdVXK7Q2XEGE4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBvkq-00000006OtO-1Wgw; Wed, 30 Sep 2026 14:57:56 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBvko-00000006Osl-0cB6 for linux-amlogic@lists.infradead.org; Wed, 30 Sep 2026 14:57:54 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9728D43789; Wed, 30 Sep 2026 14:57:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56F4A1F00898; Wed, 30 Sep 2026 14:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790780273; bh=zeczajftE7m4hge0KmE3dUIK4JSk8WdnAPf0ngXwdNM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eTT8rSESlkwe6pl12uTYzZueZAphGZA9WW+fLTgGSIL8ZlVWzKIbZVUSILQ3dz08m lZBUf7f0qXSVISPqWq7Ty5+TNlvjolEAH9J09dUdRVP83tVXaxgJ4ny+W725TLhRwX V6CmG2eISJII9d6UHU5iUOOvbyQOjKYNgxEw4LkOF9+97FWE8Kv2sCOZxp/E1Y8a9q Xc3wnLswRxs3na9xjfh8p++VcFNyNErtPPPqZzVrZHVXvLFVt63akhco9o2SAXzISd cI7WIQ/PCtWk0q+s+bEsOcDKwJkHARCBqpilz62/dthJVnjV6OgdK7AYq+KjHnUogU 9EyRrGyWqazsg== From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH 2/4] PCI: Match the hierarchy's MPS to a device's MPSS as necessary To: "Niklas Cassel" Cc: linux-pci@vger.kernel.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260930145017.1356088-8-cassel@kernel.org> References: <20260930145017.1356088-6-cassel@kernel.org> <20260930145017.1356088-8-cassel@kernel.org> Date: Wed, 30 Sep 2026 14:57:53 +0000 Message-Id: <20260930145753.56F4A1F00898@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org PiBGcm9tOiBIYW5zIFpoYW5nIDwxODI1NTExNzE1OUAxNjMuY29tPgo+IAo+IHBjaV9jb25maWd1 cmVfbXBzKCkgZW51bWVyYXRlcyB0b3AtZG93biBhbmQgcHJvZ3JhbXMgZWFjaCBkZXZpY2UncyBN YXhpbXVtCj4gUGF5bG9hZCBTaXplIChNUFMpIHRvIG1hdGNoIGl0cyB1cHN0cmVhbSBicmlkZ2Uu ICBXaGVuIGEgZGV2aWNlJ3MgTVBTCj4gU3VwcG9ydGVkIChNUFNTKSBpcyB0b28gc21hbGwgdG8g bWF0Y2gsIGNvbW1pdCA5ZjBlODkzNTk3NzUgKCJQQ0k6IE1hdGNoCj4gUm9vdCBQb3J0J3MgTVBT IHRvIGVuZHBvaW50J3MgTVBTUyBhcyBuZWNlc3NhcnkiKSByZWR1Y2VzIHRoZSB1cHN0cmVhbQo+ IGJyaWRnZSBpbnN0ZWFkLCBidXQgb25seSB3aGVuIHRoYXQgYnJpZGdlIGlzIGEgUm9vdCBQb3J0 Lgo+IAo+IFRoYXQgY292ZXJzIGFuIGVuZHBvaW50IGRpcmVjdGx5IGJlbG93IGEgUm9vdCBQb3J0 IGFuZCBub3RoaW5nIGVsc2UuICBXaXRoCj4gYSBTd2l0Y2ggaW4gYmV0d2VlbiwgdGhlIFN3aXRj aCBwb3J0cyBoYXZlIGFscmVhZHkgaW5oZXJpdGVkIHRoZSBSb290Cj4gUG9ydCdzIGxhcmdlciBN UFMsIHRoZSByZWR1Y3Rpb24gaXMgc2tpcHBlZCBiZWNhdXNlIHRoZSB1cHN0cmVhbSBicmlkZ2Ug aXMKPiBhIFN3aXRjaCBEb3duc3RyZWFtIFBvcnQsIGFuZCBwY2llX3NldF9tcHMoKSB0aGVuIGZh aWxzIHdpdGggLUVJTlZBTCBmb3IKPiB0aGUgZW5kcG9pbnQuICBUaGUgZW5kcG9pbnQgaXMgbGVm dCBiZWxvdyBhIHBvcnQgcHJvZ3JhbW1lZCBmb3IgYSBsYXJnZXIKPiBNUFMsIHNvIGFueSBsYXJn ZXIgVExQIGl0IHJlY2VpdmVzIGlzIHRyZWF0ZWQgYXMgTWFsZm9ybWVkLgo+IAo+IFsgLi4uIF0K PiBGaXhlczogOWYwZTg5MzU5Nzc1ICgiUENJOiBNYXRjaCBSb290IFBvcnQncyBNUFMgdG8gZW5k cG9pbnQncyBNUFNTIGFzIG5lY2Vzc2FyeSIpCj4gU2lnbmVkLW9mZi1ieTogSGFucyBaaGFuZyA8 MTgyNTUxMTcxNTlAMTYzLmNvbT4KPiBBc3Npc3RlZC1ieTogTExNCj4gQ28tZGV2ZWxvcGVkLWJ5 OiBOaWtsYXMgQ2Fzc2VsIDxjYXNzZWxAa2VybmVsLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBOaWts YXMgQ2Fzc2VsIDxjYXNzZWxAa2VybmVsLm9yZz4KClNhc2hpa28gaGFzIHJldmlld2VkIHRoaXMg cGF0Y2ggYW5kIGZvdW5kIG5vIGlzc3Vlcy4gSXQgbG9va3MgZ3JlYXQhCgotLSAKU2FzaGlrbyBB SSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwOTMwMTQ1MDE3 LjEzNTYwODgtNi1jYXNzZWxAa2VybmVsLm9yZz9wYXJ0PTIKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdAps aW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg==