From: Nathan Chancellor <nathan@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: cdcp206@gmail.com, "Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Liviu Stan" <liviu.stan@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] iio: temperature: ltc2983: avoid string comparison for leak detector
Date: Wed, 30 Sep 2026 17:03:36 +0200 [thread overview]
Message-ID: <20260930150336.GC3142230@ax162> (raw)
In-Reply-To: <arzb0JQxkJAsLsEa@ashevche-desk.local>
On Wed, Sep 30, 2026 at 12:52:16PM +0300, Andy Shevchenko wrote:
> Hmm... I consider that the compiler warning is just a noise which we should
> ignore or disable. It's doubtfully useful as if it may prove the always false
> or always true cases, it doesn't mean there won't be other cases in the future.
> Do we have any discussion on that warning before?
I don't think there has been a discussion around -Wstring-compare
before. Unfortunately, it seems like clang's -Wstring-compare is
different from GCC's -Wstring-compare. clang's is basically a subwarning
in GCC's -Waddress and GCC's -Wstring-compare does not really have an
equivalent in clang proper (it seems like it might be a clang-tidy
check IIUC?):
https://godbolt.org/z/zzT4WsoT8
So if we want to disable -Wstring-compare, we should only do it for GCC
in my opinion.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-09-30 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 17:38 [PATCH] iio: temperature: ltc2983: avoid string comparison for leak detector Carlos Casadiego via B4 Relay
2026-09-29 17:38 ` Carlos Casadiego
2026-09-30 9:52 ` Andy Shevchenko
2026-09-30 12:13 ` Nuno Sá
2026-09-30 15:03 ` Nathan Chancellor [this message]
2026-10-02 13:32 ` Andy Shevchenko
2026-10-02 13:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930150336.GC3142230@ax162 \
--to=nathan@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=cdcp206@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.stan@analog.com \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.