From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF3654ED1B1; Wed, 30 Sep 2026 15:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782472; cv=none; b=B52qAosAOqftePqE+Nmqk2CZfID1XmV/gkhEks2Yrm7zktQizoUPRovOzqSwX4ymapYFLhL3512ZeKzQAtUPjmUmODA2ZxP/q06brs8NCLMjjYAtVi0/xHKFOaOB0AVPTFripk2AiLBbS6MflnZZpdYunXOgTuqJuQrjDzgG45s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782472; c=relaxed/simple; bh=Cdps8yT0mjr5fB5eSozGFciDZ9DfjqMjHdzPy3Vj6Ko=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mP+h9pBCLSJspmg4I5HLkymT7JNuhOTy5ONvWara3uLlTlT/K8c0sdVlYpP0BJOAFN/h7KIyViunTYxwUjhGt7ka87lX33SRrdFf9qK/sARWmotWk9aWwCw9nddWz2SMYA54XmckcFy81vokv7TLPvjW4VhtXf6wsUq3I/4Y/Fg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Q66H4zHO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Q66H4zHO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD0011F00893; Wed, 30 Sep 2026 15:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782459; bh=CDVqh6h/RmzvKvVejCvGmKe/xbc64BPrJwQdRL51pJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Q66H4zHOn6PbgnLR6KEYEDwPV0xvaPHGicR8DCyw1Ua3Ni7Bom+jv06HCSJMy3KUn mobjXH1K/PgZZZAb0+uY/HH+IWGG2JlXGrKwBlHMRmNOpQcjPhpQ7NiVGvMhVhH2zH uJ7jyvBqdknb8CgnWGtMNpjFjwCBjpkPlDBDMrCM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marco Felsch , Sasha Levin Subject: [PATCH 5.10 053/595] serial: 8250: fix possible ISR soft lockup Date: Wed, 30 Sep 2026 17:19:06 +0200 Message-ID: <20260930152348.872265634@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marco Felsch [ Upstream commit 0c6bf45e5a345cc3b9ffbeaf9083ecac3c2293eb ] There are rare cases in which the host gets stuck in the ISR because it is flooded with messages during the startup phase. The reason for the soft lockup in the ISR is the missing FIFO error IRQ (FIFOE) handling. Not handling it and reporting IRQ_HANDLED triggers the IRQ immediately again. Fix this by adding a check for the FIFOE status and clearing the FIFO if no data is ready (DR). This behavior was observed on an AM62L device which uses the OMAP 8250 driver. Fix it for all 8250 drivers, since the OMAP driver's special IRQ setup handling may trigger this behavior more frequently, but it is not ensured that other 8250 drivers aren't affected. Signed-off-by: Marco Felsch Link: https://patch.msgid.link/20260519-v7-1-topic-serial-8250-v1-1-56b04293a246@pengutronix.de Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/8250/8250_port.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index 4b9c54ee00e8d..691b832951362 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -1894,6 +1894,13 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir) status = serial_port_in(port, UART_LSR); + /* + * Recover from no-data-ready and FIFO error condition to avoid getting + * stuck in the ISR. + */ + if (!(status & UART_LSR_DR) && (status & UART_LSR_FIFOE)) + serial8250_clear_and_reinit_fifos(up); + /* * If port is stopped and there are no error conditions in the * FIFO, then don't drain the FIFO, as this may lead to TTY buffer -- 2.53.0