From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58E484D7D50; Wed, 30 Sep 2026 15:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782631; cv=none; b=YxYEK8xEmYq00RxlYCHYOnmuHUMWtAeF53M2Eac6X54+Rf8azfwyWwTuLEzqluPzbT/PN49QCcUi5m1zU4lxoo94J2rrScvngH8jv2Cwj70jWAPjKCbs2j4Y/BbeR8ymJhOEcJ9O62OC333CrOZmEKmdFVy9Dmm4ho1QtJid4mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782631; c=relaxed/simple; bh=RiS6Kx+qW09J9u0RuHV4ri8lID94O7gyOHziW7nC0Ac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a0X80TjbbBCGX1G9V3rn09HZ+z0RLelidfaRVDBmRtohw4UIQqc23vXkNHhRf3mLLby+1ejAqlFTW4q35b+nB/tLXazN90yTt+Mo8GqmjopGH2WlLmwHGEtogQ+24n7PYhtZRDv+bVhxqtuqKD0uM1k/QZbLXT2vPcLBo5PGCg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Pu3mmNMe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Pu3mmNMe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 529171F00898; Wed, 30 Sep 2026 15:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782623; bh=m6TrySmfIdkuorK5kCthlIY/Q85AAb1vP/b8LZ4qrKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Pu3mmNMep1IIc4cNV9AlU/NV+wMc+m9BnZT9myhC/cTBUybb2PwxfvfH3zfzNWxWs kOLhzYJDc0armIBn0eiO1+/hZEy/QS6cnQWOG9vUSTGvMvdvO3SKR24QBQqZs0NDXF +gfKgdH0RLasFygVQzB6bvIPnmiMHpeY+fdSxpaE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , Breno Leitao , Al Viro , Sasha Levin Subject: [PATCH 5.10 110/595] configfs_depend_prep(): pass configfs_dirent instead of dentry Date: Wed, 30 Sep 2026 17:20:03 +0200 Message-ID: <20260930152350.103945705@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Al Viro [ Upstream commit 764682e0118432260191d194edbdaff208260483 ] Again, the only thing it uses dentry for is dentry->d_fsdata; for the recursive call the situation is the same as with configfs_detach_prep() and the same observation about ->s_dentry->d_fsdata applies. Reviewed-by: Jan Kara Reviewed-by: Breno Leitao Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/configfs/dir.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index ef86e4510c1c5..e2134e51108e5 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -1083,15 +1083,12 @@ static int configfs_dump(struct configfs_dirent *sd, int level) * much on the stack, though, so folks that need this function - be careful * about your stack! Patches will be accepted to make it iterative. */ -static int configfs_depend_prep(struct dentry *origin, +static int configfs_depend_prep(struct configfs_dirent *sd, struct config_item *target) { - struct configfs_dirent *child_sd, *sd; + struct configfs_dirent *child_sd; int ret = 0; - BUG_ON(!origin || !origin->d_fsdata); - sd = origin->d_fsdata; - if (sd->s_element == target) /* Boo-yah */ goto out; @@ -1099,8 +1096,7 @@ static int configfs_depend_prep(struct dentry *origin, if ((child_sd->s_type & CONFIGFS_DIR) && !(child_sd->s_type & CONFIGFS_USET_DROPPING) && !(child_sd->s_type & CONFIGFS_USET_CREATING)) { - ret = configfs_depend_prep(child_sd->s_dentry, - target); + ret = configfs_depend_prep(child_sd, target); if (!ret) goto out; /* Child path boo-yah */ } @@ -1121,7 +1117,7 @@ static int configfs_do_depend_item(struct dentry *subsys_dentry, spin_lock(&configfs_dirent_lock); /* Scan the tree, return 0 if found */ - ret = configfs_depend_prep(subsys_dentry, target); + ret = configfs_depend_prep(subsys_dentry->d_fsdata, target); if (ret) goto out_unlock_dirent_lock; -- 2.53.0