From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AA5F50E5B3; Wed, 30 Sep 2026 15:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782771; cv=none; b=qLPLMKzTvL3BCUaybGDLFOXnYl9Btpaz74WcrPoI52VnCtYxyhP9vXfCIiZf0Q5z5dYc9keG0Imgek27EjvzGBb17DYcVARlpHie0ioh9jU6bOyH/SeOS/rwwn1e75k0l3VLiKuRLeASehGo6T/rIHKk9s90DeE4aqzdpIIW4K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782771; c=relaxed/simple; bh=k7WawpBoyPNONN32gvN64HkNJUskTvaRNiaaSC4sgrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pIuR54O04YtrzmB9c5TKyB4RECUkWIZCcvZlrSxKU1REO6u90BT2IxpOa/xrA5ULQgX9I9HMK8aCWaWSKqDYz+arza6HV/7F1iMIVjCA40I1NKgNzj6gZErn6zkpgWjj60ysHNxVbuKvfHGo2TKWBfE7iY3vyA1kXqMTGWfuqCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1BOrqOKt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1BOrqOKt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC1161F00893; Wed, 30 Sep 2026 15:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782763; bh=Lh7BRpcIFHs2S0/KVJTBqjHXSQOWJdSHXYBf69ALR3s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1BOrqOKt2xFmE8GYgppATjECwRNyr3JR+Ud15IZ9agr+WFE91mot5mgLGcT5Hnnay kAij7ucEVvFW7epbtJakWqMEV1mbaU8gmemchyQChRdO+kJctLxrlHDfJRecyJfGkA rXKgxhDLDq6XH5casyfAI7K1u2j9bt/zqe1/fgp8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nikolay Metchev , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 5.10 116/595] platform/x86: intel-hid: Add HP ProBook x360 440 G1 to button_array_table Date: Wed, 30 Sep 2026 17:20:09 +0200 Message-ID: <20260930152350.232680147@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nikolay Metchev [ Upstream commit c39023ca9a447f09c072080efc84d6874c2275c9 ] The volume rocker buttons on the HP ProBook x360 440 G1 convertible emit events 0xc4-0xc7 via the intel-hid ACPI device (INT33D5). These codes are only present in intel_array_keymap, which is used when the "5 button array" input device exists. On this machine button_array_present() returns false because the firmware does not advertise the array through the HEBC method, so notify_handler() routes the events to a NULL priv->array and they are dropped as "unknown event 0xc4". As a result the side volume keys do nothing. Add the machine to button_array_table so the array device is created and the volume rocker emits KEY_VOLUMEUP / KEY_VOLUMEDOWN. This is equivalent to booting with the enable_5_button_array=1 module parameter, which was used to confirm the fix on the affected hardware. Signed-off-by: Nikolay Metchev Reviewed-by: Hans de Goede Link: https://patch.msgid.link/20260609213309.445019-1-nikolaymetchev@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/intel-hid.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index f52367363d530..ccb4b7233e798 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -114,6 +114,13 @@ static const struct dmi_system_id button_array_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 4"), }, }, + { + .ident = "HP ProBook x360 440 G1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook x360 440 G1"), + }, + }, { } }; -- 2.53.0