From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0FE4F30F0; Wed, 30 Sep 2026 15:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782786; cv=none; b=XI/ZJw6qBIrja8BRq1U/xMUt1UxJz1HUr8wIXWd91y1IR4h9RpgS74AARhBCNMQfiL1U+Z6TbNt6vDpPeF14ivl0gYVHsEUGbs9fFyfAwNFT/cDG+n3eBMCMAIbQt5EVcTz/CpwBbe+ZpJbHep5XzPCQPoGvD9az4ywrVvPx0tE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782786; c=relaxed/simple; bh=jjJCPGMXMxgDVG3U+c+NV4Tn0t6KHuM0Y4xhxwZebJc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=huGsP+ot+eR8k1aoqIux5HyqCPin5DT2sRsS/6SsQNNj/l4vkii+zycuPwdH92sVq+PhO0BB/8UOpSXAVvrPxBjsbWclv70ocg22KflAFOSYbw7tHxZVUUQcbaGuC02gIVk5hESWjS7W+5M/j6Vx40O5ohwIPtAR43oXShMVUgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WocsF9kL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WocsF9kL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D81F1F0089A; Wed, 30 Sep 2026 15:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782780; bh=Cvux4F0gKcS1PecDA36fv5N/2BnwZz2FjUcbM28a3zI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WocsF9kLE4dHKUVa0YT9RWOUtO8bR+ynGFHmgHeCsstiUWxfH4Mf2sDENFuKarzNG ZJLsZZ4vYViOLgzlD7TzfhS248Z/ZyqfY++v/qvUN2JhsCa1lGziZd8hcLfEN8QrOU ZECLzLB40RevHLiSI7mMUZF3CzmikQmwAhufs3Ck= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Johannes Berg , Sasha Levin Subject: [PATCH 5.10 160/595] wifi: libipw: fix key index receive bound checks Date: Wed, 30 Sep 2026 17:20:53 +0200 Message-ID: <20260930152351.178012681@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 74ed3669f26803b1761c1f55403062bea44c3466 ] libipw_rx() reads skb->data[hdrlen + 3] to extract the WEP key index in both the software-decrypt key selection path and the hardware-decrypted IV/ICV strip path. In both places the existing guard only checks skb->len >= hdrlen + 3, which proves bytes up to hdrlen + 2 but not the byte at hdrlen + 3. Require hdrlen + 4 bytes before reading that item in both paths. This is a local source-boundary check only; it does not change the key index semantics. Signed-off-by: Pengpeng Hou Link: https://patch.msgid.link/20260705083519.23567-1-pengpeng@iscas.ac.cn Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/ipw2x00/libipw_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c index 4c6e742c56958..59b78337ae652 100644 --- a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c +++ b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c @@ -417,7 +417,7 @@ int libipw_rx(struct libipw_device *ieee, struct sk_buff *skb, ieee->host_mc_decrypt : ieee->host_decrypt; if (can_be_decrypted) { - if (skb->len >= hdrlen + 3) { + if (skb->len >= hdrlen + 4) { /* Top two-bits of byte 3 are the key index */ keyidx = skb->data[hdrlen + 3] >> 6; } @@ -663,7 +663,7 @@ int libipw_rx(struct libipw_device *ieee, struct sk_buff *skb, int trimlen = 0; /* Top two-bits of byte 3 are the key index */ - if (skb->len >= hdrlen + 3) + if (skb->len >= hdrlen + 4) keyidx = skb->data[hdrlen + 3] >> 6; /* To strip off any security data which appears before the -- 2.53.0