From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D297833B6F1; Wed, 30 Sep 2026 15:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782818; cv=none; b=mmlZphpvfOXVcu8rc2rnZk++XyiQvmeNK0cAGpGYnvXAsA/tP0/07cJGq6IcujFSW+XTaaOMfxbOqHzQ/fbrD2QjEZgXoaLnefqfFZCsYL43Eub1y35S26F+RFbsKS40uKCvE4kkhArQGJNxRhumtZDVborBnT2wRLk13684zEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782818; c=relaxed/simple; bh=urjmzojcvEM4FA9UVPOL75l9VX1ajgWNh+Fw4/+F1F4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TIljhbbT+Q1iQAKUVwLtZJ4lyZC91orDvffgFZSzhYlBpwDUTD79e7Rkbqv56qEA8umcKVImSOdcUK21ptYsrOrOo2YiZkJrRx6u6AJEyBidMn/PW8zm7W01BdJ41AGe/GPlKa5K2S81vXMz9rQGS0vIf/zCJtiSb7ccbmfRDfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=b0GrEbAm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="b0GrEbAm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A0C01F00898; Wed, 30 Sep 2026 15:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782814; bh=wjdfHtAKcGNWmAlqB86VEoq442dE/zdFinIRQhkMDNg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b0GrEbAmnl9kwNcmxSg0APao7s2IYr+skKVd/SSiYq4W0oz1G5Pqgah+35sG2C/0G KcBrXA5cJ4bqyDaH9J5vWb4fR7H36IdeDgfpIjAmc5PS/zkgnh1LdySznKYu3w3AHc pRhSoaLUcWH9WAew6QefwDrTHAy55VaPqvSUE1XQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+cc867e537e4bd36f69bb@syzkaller.appspotmail.com, Deepanshu Kartikey , Johannes Berg , Sasha Levin Subject: [PATCH 5.10 179/595] wifi: cfg80211: validate IEs in cfg80211_wext_siwgenie() Date: Wed, 30 Sep 2026 17:21:12 +0200 Message-ID: <20260930152351.590697623@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Deepanshu Kartikey [ Upstream commit a2f5286ca4f304d3fd469f01b96b518608912a5c ] The KASAN allocation trace shows that a malformed IE buffer is stored via SIOCSIWGENIE (cfg80211_wext_siwgenie()) without any validation. The crash trace shows that a subsequent SIOCSIWESSID triggers a connection attempt which calls cfg80211_sme_get_conn_ies() to process the stored IE buffer, causing: - An out-of-bounds read in skip_ie() which reads ies[pos+1] (the length byte) past the end of the 1-byte buffer. - An integer underflow in the memcpy size argument when offs returned by ieee80211_ie_split() exceeds ies_len, causing unsigned subtraction to wrap to SIZE_MAX and triggering a fortify panic. Fix this by validating the IE buffer in cfg80211_wext_siwgenie() before storing it. Reported-by: syzbot+cc867e537e4bd36f69bb@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=cc867e537e4bd36f69bb Signed-off-by: Deepanshu Kartikey Link: https://patch.msgid.link/20260725142028.32560-1-kartikey406@gmail.com [drop unnecessary ie_len check, update commit message] Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/wext-sme.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c index 73df23570d43a..d27ec0163b08b 100644 --- a/net/wireless/wext-sme.c +++ b/net/wireless/wext-sme.c @@ -333,6 +333,15 @@ int cfg80211_wext_siwgenie(struct net_device *dev, goto out; if (ie_len) { + const struct element *elem; + + for_each_element(elem, extra, ie_len) { + /* nothing */ + } + + if (!for_each_element_completed(elem, extra, ie_len)) + return -EINVAL; + ie = kmemdup(extra, ie_len, GFP_KERNEL); if (!ie) { err = -ENOMEM; -- 2.53.0