From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 326C24FC8E0; Wed, 30 Sep 2026 15:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783062; cv=none; b=kRcNMOSQBjsGaL1qibThsCuqffOloPbVpCDveRO0Uz2/+WzTZCBsHeeTtzLoc22kbV+rgKdwk1a+k7iuM8oRlGw7cgbf4lApfLvZMRCCF5aLRkBuuw8mVN5AKAhSJNAYwkAr95ioQK29l3I1gPSGKnQWdVBAEzbAUT75yg0KJOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783062; c=relaxed/simple; bh=HFpgE3oKkYDH2ABkvLTpOGmGYh6IgNr7RyCz3LwsM58=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UnG+EVJSOejyBUsaUX35FDvpZOrSMh/7PbLEXdgeRTm3rlCUAnKFgFlbNoG4fLCFQKebHNvaKcx8/DsRloLwRz1dfZmokFysdR96G/ucGBfkJEOWxCs0UDgkvskxkAkgVwdXEVGXj2axRehrBQpyjvKi0y2ME+2r9bOC2c1pHXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IAUS/2tL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IAUS/2tL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BB5A1F00898; Wed, 30 Sep 2026 15:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783055; bh=RtawGo/G1TzhinRYNFXzI7rLeJhveenW0f2xo19I2Gk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IAUS/2tLPy1PehAtc5NGYsTjNza5nveJTKwWGbUAGowCDd31pRsSN7Qc4xTabcShq +aWcBJ0zK6//pmpcW921LQIb/1DVjpvv3XvBdvQV2KkdaFA/eJMsXAUHbUTu0a4coq VA5si5z5q7Eu+usbpT+r6UV7lrD0Knzp3N32tq5E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Michael S. Tsirkin" , Andrew Stellman , Sasha Levin Subject: [PATCH 5.10 265/595] virtio-pci: return IRQ_HANDLED after non-zero ISR Date: Wed, 30 Sep 2026 17:22:38 +0200 Message-ID: <20260930152353.408537123@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Stellman [ Upstream commit 93fa09455fb1a9624b73d42ac1f83771f4818e80 ] vp_interrupt() reads the ISR before dispatching config-change and vring handling. Reading the ISR also clears it, so once the read returns non-zero the interrupt was from this device and has already been consumed. Currently vp_interrupt() returns the result of vp_vring_interrupt(). For a config-change interrupt with no vring work, that can return IRQ_NONE even though the ISR was non-zero and the interrupt was handled. Call vp_vring_interrupt() for any queue work, but once the ISR is non-zero return IRQ_HANDLED. Tested with QEMU virtio-blk-pci forced to INTx using vectors=0 and pci=nomsi. On an idle device, 200 config-change interrupts were generated using QMP block_resize. Before this change, irq_handler_exit reported ret=unhandled and /proc/irq/11/spurious increased from 0 to 200 unhandled interrupts. After this change, irq_handler_exit reported ret=handled and the unhandled count remained at 0. The issue was found during an LLM-assisted Quality Playbook review. Fixes: 77cf524654a8 ("virtio_pci: split up vp_interrupt") Suggested-by: Michael S. Tsirkin Assisted-by: LLM Signed-off-by: Andrew Stellman Message-ID: <20260904141318.30278-1-astellman@stellman-greene.com> Signed-off-by: Michael S. Tsirkin Signed-off-by: Sasha Levin --- drivers/virtio/virtio_pci_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index a6f375417fd54..437622cd079f5 100644 --- a/drivers/virtio/virtio_pci_common.c +++ b/drivers/virtio/virtio_pci_common.c @@ -96,7 +96,9 @@ static irqreturn_t vp_interrupt(int irq, void *opaque) if (isr & VIRTIO_PCI_ISR_CONFIG) vp_config_changed(irq, opaque); - return vp_vring_interrupt(irq, opaque); + vp_vring_interrupt(irq, opaque); + + return IRQ_HANDLED; } static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, -- 2.53.0