From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71D7937EFFE; Wed, 30 Sep 2026 15:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783132; cv=none; b=d95Mx/D7NCJtnfV4bfSI9UI6piIm/CAKAkh0Q6E7K8saAnjwKsVjwwXoXZFBaAjRMTyR3diN+kqKNn6+MKoFGmXj5syJ5r6gMtjfTp/KhYUaqpIkw79s5kqJ4wbDkG/4heABCTsYhi/ZMZHrL+6qqJVYwlNl/k+tOlmEPlqiOyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783132; c=relaxed/simple; bh=PN6U1qeoXJTwu47DcOcxHgIulM70GgW2f8CTH+Mo7BM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aCyeY5NBFOagdprEY/w2vZnAoqSIl7l0yHCmkkdUsBIkIfgd1HDQbliDl58uMAxF3t5Ml/38r2loJmQ8jQFI7F8n/5cjZiCXylx0gHAYgUGxVWv6y5ca/RoJJxsVz3aS0LTetBibE0BA3i2iEDusjM4ez1Gl0N2ACab5MwwUBDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mE8Prg6a; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mE8Prg6a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86A5F1F00899; Wed, 30 Sep 2026 15:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783126; bh=2GXb31maeY8z/LDJ8jgxwu3wDrFAv1vrO+y1R+h1WLc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mE8Prg6aY9mrhILwIXOom4+QYp0mLyZW+MP17xdEkF9WQe09C2H9aceRXdgoXHF0W EyoPpceNf4dQ50H1dfpr94GQR1GoY79XSANLJCL3iDIUagN+34j78eyX40/pay31dD hqYwSlj8xduAS52adnpX5AFc1n4jjXHXUjQYsUNQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vega , Luxing Yin , Zihan Xi , Ido Schimmel , Jakub Kicinski Subject: [PATCH 5.10 288/595] ipv6: fix fib6 walker UAF on seq stop Date: Wed, 30 Sep 2026 17:23:01 +0200 Message-ID: <20260930152353.891837007@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zihan Xi commit 19b4ed644d68098cc62ab612727f40d30f43476c upstream. ipv6_route_iter_active() treats a walker in FWS_U at the table root as already unlinked. fib6_del_route() can move a still-linked walker into that same state when the current leaf is the last route at the root, so ipv6_route_native_seq_stop() skips fib6_walker_unlink(). The seq private object can then be freed while it remains on net->ipv6.fib6_walkers. A later route deletion walks the dangling list and uses the freed walker. Use the list head as membership state and reinitialize it when unlinking. Keep the existing w->node check so a never-started iterator with a zeroed private object is not treated as linked. The same stop helper is used by /proc/net/ipv6_route and by the BPF ipv6_route iterator. The BPF show path only widens the race. Fixes: 8d2ca1d7b5c3 ("ipv6: avoid high order memory allocations for /proc/net/ipv6_route") Cc: stable@vger.kernel.org Reported-by: Vega Co-developed-by: Luxing Yin Signed-off-by: Luxing Yin Signed-off-by: Zihan Xi Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/89699735763f6c297584d7c2ff106239cc1e8ce0.1788837093.git.zihanx@nebusec.ai Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv6/ip6_fib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -83,7 +83,7 @@ static void fib6_walker_link(struct net static void fib6_walker_unlink(struct net *net, struct fib6_walker *w) { write_lock_bh(&net->ipv6.fib6_walker_lock); - list_del(&w->lh); + list_del_init(&w->lh); write_unlock_bh(&net->ipv6.fib6_walker_lock); } @@ -2637,7 +2637,7 @@ static void *ipv6_route_seq_start(struct static bool ipv6_route_iter_active(struct ipv6_route_iter *iter) { struct fib6_walker *w = &iter->w; - return w->node && !(w->state == FWS_U && w->node == w->root); + return w->node && !list_empty(&w->lh); } static void ipv6_route_native_seq_stop(struct seq_file *seq, void *v)