From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA4D385535; Wed, 30 Sep 2026 15:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783146; cv=none; b=fMIci1FWmbVLc6rK3rKeG6QuK8aB0pGA8C+t4+FnpcrpyMbxPa1dSb0G0wGKm6yO5CR9jHoaCGOzWgHD7A4ss71tzWfycFdnJqDu29cKpVowNn9roGvnu+JHet+QpWYrKcrG5NqHimOL44TkKGrBg/FmqYrlNpYiit+1q4QG/Kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783146; c=relaxed/simple; bh=zMS7U12D3KsqZlZBrNyQ1g/eb/M3NetT4EoA5VBvqdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lBG7BDloDjRw/UiNPL0KfgBuYMbY7VUJ9vXfOhJ0N0uMAFbGkMdKYjBNf3M+b7AXLYthfl+f441y8ROzLXevNJE86xT57NAFxbEGO1EQO0F9GmsG1O8NGirXfsQ46Y+om/azZWCiRzDgp13tLFZy6EH/+9YpwxyU7pzIj9PNjHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gB9dg4hX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gB9dg4hX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1D871F000FF; Wed, 30 Sep 2026 15:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783137; bh=pg7jRa257BS+lZArHi4PT3WdyS/yo/WBd/g6jGCreY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gB9dg4hXqpRnzMYegr68jn1ovP/1+SLeZV4ng6kQALTQcRadihcn4d4GXA4kv2QFh dFXHjT2Cow4QiQsWtC/SW/Rd/EPtcLsw4EVBzrrVTpwygzaZ1hY2ObpN+uKmtYEqIR n5ihpt8d1STLnQRjcCKFrDqtZRPHf9EBhz9DxawI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ali Ahmet Memis , Jan Kara , "Christian Brauner (Amutable)" Subject: [PATCH 5.10 292/595] ufs: create the root dentry after loading cylinder metadata Date: Wed, 30 Sep 2026 17:23:05 +0200 Message-ID: <20260930152353.976853998@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ali Ahmet Memis commit 55a4c98abb9694b067c6a031d11501f06b6b523c upstream. ufs_fill_super() installed sb->s_root before it loaded the cylinder group structures for a writable mount: sb->s_root = d_make_root(inode); ... if (!sb_rdonly(sb)) if (!ufs_read_cylinder_structures(sb)) goto failed; When ufs_read_cylinder_structures() failed, the error path freed the in-core superblock information and set sb->s_fs_info to NULL while sb->s_root stayed installed. get_tree_bdev() then reached deactivate_locked_super(), and because s_root was present, generic_shutdown_super() called sync_filesystem() and the put_super operation. Both dereference UFS_SB(sb), which is now NULL, so a mount that fails only while reading the cylinder groups oopses during teardown. A crafted image whose first cylinder group cannot be read reaches this path. Load the cylinder group metadata first and create the root dentry last, so the superblock is published to the VFS only once it is fully set up. ufs_setup_cstotal() and ufs_read_cylinder_structures() take only the super_block and do not use the root inode, so the reordering is safe. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Ali Ahmet Memis Link: https://patch.msgid.link/20260801071306.59484-2-ali@iusegentoo.com Reviewed-by: Jan Kara Signed-off-by: Christian Brauner (Amutable) Signed-off-by: Greg Kroah-Hartman --- fs/ufs/super.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) --- a/fs/ufs/super.c +++ b/fs/ufs/super.c @@ -1269,6 +1269,15 @@ magic_found: sb->s_maxbytes = ufs_max_bytes(sb); sb->s_max_links = UFS_LINK_MAX; + ufs_setup_cstotal(sb); + /* + * Read cylinder group structures + */ + if (!sb_rdonly(sb)) + if (!ufs_read_cylinder_structures(sb)) + goto failed; + + /* create the root dentry last, once UFS_SB(sb) is fully set up */ inode = ufs_iget(sb, UFS_ROOTINO); if (IS_ERR(inode)) { ret = PTR_ERR(inode); @@ -1280,14 +1289,6 @@ magic_found: goto failed; } - ufs_setup_cstotal(sb); - /* - * Read cylinder group structures - */ - if (!sb_rdonly(sb)) - if (!ufs_read_cylinder_structures(sb)) - goto failed; - UFSD("EXIT\n"); return 0;