From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57A1A4FB9C9; Wed, 30 Sep 2026 15:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783197; cv=none; b=fVvAINtiBKE24zWZlJFK8pNYRQTjDrtKHXpvhJmCP/2hxGfN/gejlNFzStQZ8sJXNUktSQUWmvvvMcUacqUwq3emhPK0MvR1JcoyCesxXLbMx5qY8Y1OpH7H5Pou0aBzbyiymtjf5oFUxVe3HD4tUN16lp58xYsFLPMJwKOqUAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783197; c=relaxed/simple; bh=eq+AkDWjbZtXjJUReGgG0j5YEhnh/n1XPsGkh1EjGwI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ISKJC/XLOJkvoHC+udcWYieQLDD8gORIpBBcBE3hCR0sOwywcP1DCtX4MuwQtbRCTzjlZtC0xsVXu8uq8hH+wNCUCKgSZt/bA4Jy77A9xVGV4grUhfrVVPMgdX0mLyxlVioQRuwypC4RkwafW624/8BrnZL3tNzHA+NxNE1eZ6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H5T32ilV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H5T32ilV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED0E81F0089A; Wed, 30 Sep 2026 15:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783191; bh=D8Pt866I/tUGp/L6aNf7Rpvy1iVxmEVymu3IcCyqhUA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=H5T32ilVIQ5MbnzH4aBztx1H0sRVtaNs02elFPKxi8j+CCK/CcK3WuAPvX7ORSPSL QwAZyJfgrKtb5Ey7DFxBiEFHR7k0/nxvo9fRQe20CbCFxuuFaeGjQazCy1K+FKE2Ew oEZaWKTPYcYNJLvv3CaYg2NAT6q0Hzi70hFfypHA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cong Nguyen , Guenter Roeck Subject: [PATCH 5.10 313/595] hwmon: (applesmc) fix key backlight workqueue leak on register failure Date: Wed, 30 Sep 2026 17:23:26 +0200 Message-ID: <20260930152354.422242924@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Nguyen commit 5a0aacaa2d593d7582ecfe289529b937b6dc5d3c upstream. applesmc_create_key_backlight() allocates applesmc_led_wq before calling led_classdev_register(). When register fails, the error is returned to applesmc_init(), which jumps to out_light_sysfs and skips applesmc_release_key_backlight(), leaking the workqueue. Destroy the workqueue on the register failure path. The bug was introduced when the inline init block was refactored into a helper that returns errors directly, dropping the old out_light_wq unwind label. Fixes: 0b0b5dff8967 ("hwmon: (applesmc) Simplify feature sysfs handling") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen Link: https://patch.msgid.link/20260828105413.2401385-1-congnt264@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/applesmc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -1249,12 +1249,17 @@ static void applesmc_release_light_senso static int applesmc_create_key_backlight(void) { + int ret; + if (!smcreg.has_key_backlight) return 0; applesmc_led_wq = create_singlethread_workqueue("applesmc-led"); if (!applesmc_led_wq) return -ENOMEM; - return led_classdev_register(&pdev->dev, &applesmc_backlight); + ret = led_classdev_register(&pdev->dev, &applesmc_backlight); + if (ret) + destroy_workqueue(applesmc_led_wq); + return ret; } static void applesmc_release_key_backlight(void)