From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 266E6277CA5; Wed, 30 Sep 2026 15:49:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783388; cv=none; b=jCSaGwAiscrqG+paCpIfIV0U50QTr1HhCnO3nC2q7/qszsk3aRRJBg7Gc+vdxJw73uynyc2DXD7SV0a6nypwmCQmQ6wx/d18bxl9DIPChdA7EISD91vjRbV8AqUtNz45qYN3Q/DOXcWTq9QDwuS0b/VE5FB5gKbTPnO97k0BSNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783388; c=relaxed/simple; bh=K4R/DfuX8mK2A5NEP62vA2OX/uLOugU/H3blmzZ6kmU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KWaR+0D/X122U9HOzodCVfQe8smNu3rHjI+T3ZGPi4BbbtiOZh70B6eBkWOmipZ485GeAqYcoWom2qZzWd2Wo+AQfanpZsF3V1hegF8qE1leTE+Dq4JmwLjQCgXED2jrzDw6uG9yvB1EDTowb1dAgA9CfwVwci4PKYoHEXUi8kQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VYKpkmo6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VYKpkmo6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 591F21F000FF; Wed, 30 Sep 2026 15:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783381; bh=YbvZ8ZSzqIdIwUkMetCxCS/0EeP8ZBq///+V17P2Wh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VYKpkmo6WaOzoHkjNGMQ//PnbXRlC092GD9OEcJjYTCc4IhYpoHwlQ0xgUcLWsht0 dWffUSJZbRcHTHsP/PbRbYkOP8+qRQYj3Mfs6ZxlFWXmEradqc0TAJU2GVEXMGUTvn LcYvhOoe5g14DTw7ABRq1uGh4xGrYFQwws0UZHNU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Frank Li , Logan Gunthorpe , Shivank Garg , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 379/595] dmaengine: Fix device kref underflow in dma_chan_put() Date: Wed, 30 Sep 2026 17:24:32 +0200 Message-ID: <20260930152355.829746196@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shivank Garg [ Upstream commit 44dab659064eb5c10adb0306510eebe848ed592d ] dma_chan_get() takes chan->device->ref only on the slow path: /* no kref on fast path */ if (chan->client_count) { __module_get(owner); chan->client_count++; return 0; } if (!try_module_get(owner)) return -ENODEV; if (!dma_device_get(chan->device)) { // calls kref_get_unless_zero() dma_chan_put() drops the ref unconditionally, so every fast-path get/put pair drops one extra device reference. The bug fires when two conditions hold together: a non-private provider has a persistent client holding chan->client_count > 0 and another client cycles dmaengine_get()/dmaengine_put(). When the kref hits zero, the subsequent dma_find_channel() returns NULL even though the provider module is still loaded. Fix this by dropping device->ref only on the last put, matching the single slow-path get. Fixes: 8ad342a86359 ("dmaengine: Add reference counting to dma_device struct") Reviewed-by: Frank Li Reviewed-by: Logan Gunthorpe Signed-off-by: Shivank Garg Link: https://patch.msgid.link/20260822-dmaengine-kref-fix-v5-2-d4a4ee47d927@amd.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/dmaengine.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 68078e83d5756..7eb3ec8323ccc 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -513,7 +513,9 @@ static void dma_chan_put(struct dma_chan *chan) chan->route_data = NULL; } - dma_device_put(chan->device); + /* This channel is not in use anymore, drop the device ref */ + if (!chan->client_count) + dma_device_put(chan->device); module_put(dma_chan_to_owner(chan)); } -- 2.53.0