From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CA04FDE62; Wed, 30 Sep 2026 15:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783401; cv=none; b=c+0oZFF8yJieDFlZ6rHoLmpvvd9XNG122PbqE1eRlDG/Dsk+u1bugNgc0Ue4Is7pWu3GRmsDQJvEtDOPAefez2PKiTddxTt4dMGLPNaGEDrlPOEjt292sNBGGFpLlLPFMDlpyVPv8LnHYoGiiyc4/22RZ3Uc7z9lqe86Z+4hI/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783401; c=relaxed/simple; bh=wOTSTMlbHhk7npWt7Uy7mS9d17EDFHUy+P1y/YfvRyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KcR/m3s2gKoeWwzN+iyfCCVdghDVzfXSEDyFWKvhngdUfBZaLHsAYQikTDTmI9mg528Psz2P//IMyB9+HJH/8TuLEPXBDZ/VzG1kY4fJYUvytSw+GzkGOXgez6iGtLc1tdOaKWTjLE+3V/ZWA+S8NKoMutropjagNn9J62HAPmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rveQHxe7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rveQHxe7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4870E1F000FF; Wed, 30 Sep 2026 15:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783398; bh=nomDaeT5XRUH+R3MSmNmfoBuPAWw29ScUyGFXh1ExYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rveQHxe7s5nHGgHjCDz+oYjtJEqmUFe/bJtChZvbNSgq9o9dT2THRUgiF/qh6BBgK vbD5rkPz0FdfI/ZQ/TlqVsOZHh1KnfzKxH+YA9/CwnTw6mWXaqsKMJPP2U9qg/MQ2P 2DvcnLhOaS8WjUyZtzVCc3WN3P9S/uE2YB37RwPA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+de3ee5362db09487ea37@syzkaller.appspotmail.com, Johannes Berg , Sasha Levin Subject: [PATCH 5.10 384/595] wifi: mac80211: reset the AP_VLAN tailroom counter on ifdown Date: Wed, 30 Sep 2026 17:24:37 +0200 Message-ID: <20260930152355.934337821@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Berg [ Upstream commit 4504f3960dc4501c73be9f99eabda2e26e9db41e ] On ifup, AP_VLAN interfaces get crypto_tx_tailroom_needed_cnt from the AP interface, but it's never decremented again unless the AP is also brought down. Thus, bringing the same AP_VLAN up again will increment the counter again and eventually hit the sanity check: WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt != master->crypto_tx_tailroom_needed_cnt); Reset it on ifdown to avoid that. Assisted-by: LLM Fixes: f9dca80b98ca ("mac80211: fix AP_VLAN crypto tailroom calculation") Reported-by: syzbot+de3ee5362db09487ea37@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=de3ee5362db09487ea37 Link: https://patch.msgid.link/20260908122838.201719-14-johannes@sipsolutions.net Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/iface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 9abec4f929ca0..bb42a85883216 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -522,6 +522,8 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, RCU_INIT_POINTER(sdata->vif.chanctx_conf, NULL); /* see comment in the default case below */ ieee80211_free_keys(sdata, true); + /* increased by AP value on ifup, so reset on ifdown */ + sdata->crypto_tx_tailroom_needed_cnt = 0; /* no need to tell driver */ break; case NL80211_IFTYPE_MONITOR: -- 2.53.0