From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4B54BFE6D; Wed, 30 Sep 2026 15:50:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783430; cv=none; b=Vc9Ll+azp5XrVh6MGWUZMCXCh7/HTNrWJT4dPepTr16tmDJylieVvSIPC9tSL1i9yX4e/GRdVlHJTAqTpjIytzwNisa3FhWffKNwOQF2I+68xKEwauYu0RNdGgu4P6fbVPUZw1u+tOERi5X45sB3ucJCeDyolL3dxD5nJp3LVgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783430; c=relaxed/simple; bh=z3YBuUSVMLBCIUOSHXeSSnoC93LBTGSClVrCPmJq9mU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NDShO7mrl2KRuQ5w2P+sCXa79ziko5nVciJCu59NfSHSkqZKdzh9H+9+Ynz4/vvbG36D9/jw4qfIBcjbvo0S8V96ModpDHpAbt57XbPU7agXXD2f5kNluOU+6KPFhj+IxhKw11E2WhtOfm+zBxrdQLBrj0D+IFmDBrcOu0c1NVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IaZNxGlR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IaZNxGlR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DF1E1F000FF; Wed, 30 Sep 2026 15:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783427; bh=H3bsKLhASD5xgVIM7V9Qh39iQG4EpTo0K5ArDanFTeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IaZNxGlRfJeswlhekqIVA12otjSy4yNs7SdY4B3BVwciyJxB78MW9C67sP7TUNWpm HG5jCnzgyyOGz+cs6PH90g5f8x+7TTpl2bwQx4g29w0RGxl5eESLhbM5XnejeZi0lL DurIRuPxfE9D9HEMhKi75AtuecdueQEPpItnIC0g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Karl Mehltretter , Jarkko Sakkinen , Sasha Levin Subject: [PATCH 5.10 393/595] keys: fix lost wakeup when reaping a dead key type Date: Wed, 30 Sep 2026 17:24:46 +0200 Message-ID: <20260930152356.127631937@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Karl Mehltretter [ Upstream commit 2725ab3f5ad1c5f375c7c9fee4af02a9b138f701 ] clear_bit() is atomic with respect to the word it modifies, but it is an unordered operation: it implies no memory barrier on either side (Documentation/atomic_bitops.txt). key_garbage_collector() clears KEY_GC_REAPING_KEYTYPE with clear_bit() and calls wake_up_bit() after reaping a dead key type. wake_up_bit() uses a lockless waitqueue check and requires a full barrier after the clear. The existing smp_mb() is before clear_bit(), so nothing orders the clear against that check. The GC can see an empty waitqueue while unregister_key_type() still sees the bit set. The final wakeup is then lost, leaving module unload stuck in wait_on_bit(). Use clear_and_wake_up_bit(). Its clear_bit_unlock() has RELEASE semantics, so the completed GC work stays ordered before the clear, and its smp_mb__after_atomic() orders the clear before the waitqueue check. Fixes: 0c061b5707ab ("KEYS: Correctly destroy key payloads when their keytype is removed") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter Link: https://lore.kernel.org/r/20260821025327.61488-1-kmehltretter@gmail.com Reviewed-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen Signed-off-by: Sasha Levin --- security/keys/gc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/security/keys/gc.c b/security/keys/gc.c index eaddaceda14ea..285ebbf490f04 100644 --- a/security/keys/gc.c +++ b/security/keys/gc.c @@ -324,9 +324,7 @@ static void key_garbage_collector(struct work_struct *work) if (unlikely(gc_state & KEY_GC_REAPING_DEAD_3)) { kdebug("dead wake"); - smp_mb(); - clear_bit(KEY_GC_REAPING_KEYTYPE, &key_gc_flags); - wake_up_bit(&key_gc_flags, KEY_GC_REAPING_KEYTYPE); + clear_and_wake_up_bit(KEY_GC_REAPING_KEYTYPE, &key_gc_flags); } if (gc_state & KEY_GC_REAP_AGAIN) -- 2.53.0