From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70676503918; Wed, 30 Sep 2026 15:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783468; cv=none; b=CZWtwrJePd+008dEYYgBAuYnHnBrFFQAL+muVjQrP7OcWI00reAp/18y8JznD+pIpJ3bn9ajU+gTHLLfOrL/TwNbcgrlnhPfXrFBmvK7tRpWEMPAfuo0TxeD7YQSRrGwgVDRmKxlA8a9WVuhCIKwXgDqDXHztuGb1OuSiCmzUdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783468; c=relaxed/simple; bh=80jOdbOUgNc0V5o7AP0MQnUx1iK+9NbB6JWcRM5md3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nEfUCLMdIdTBoQWvEboOduZmBzUWCwXhs/33zHlY6HoLafDAsI+SJ4qm8oooWRjnS4kG/4iHzdDizFVE9qEe4+YUJTYQIG+d5zrMANzHg/GQRnf9n81jUU0OaOtkUsJlUQqVZqqfHhtXWY18MymkNUVV7hJS0Os9tGS8eyr9WmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LwMUGee/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LwMUGee/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A11E41F00893; Wed, 30 Sep 2026 15:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783464; bh=ugsxPyJtU5MfdzvsLytMYDOLwJxMLGQmCMVmBSOl+90=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LwMUGee/Xg3nsCcI/brcsvCojzTyZ9gkJtWrfaPKbBSKpcE0/aisai2KswiDxK/Z4 4iaXHlLSZ0vNbR+LC9DoSUiowBC7xYZCdFBokIOyCfuZNH865NyCgugx3B6WIkADGo jZoEZoqMoVlZVFPnddzJoqFQfr3Q4GUjiKodrEX8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Ritesh Harjani (IBM)" , R Nageswara Sastry , Shivaprasad G Bhat , Gautam Menghani , Madhavan Srinivasan , Sasha Levin Subject: [PATCH 5.10 409/595] powerpc/iommu: Fix the overflow validation in iommu_tce_check_ioba Date: Wed, 30 Sep 2026 17:25:02 +0200 Message-ID: <20260930152356.473465256@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shivaprasad G Bhat [ Upstream commit 0b271f7d7f5ed45bc498a03ce0aa9cfd8402fc71 ] The commit b1af23d836f8 ("KVM: PPC: iommu: Unify TCE checking") unified IOBA parameter checking across KVM and VFIO into iommu_tce_check_ioba(). While doing so, the passed in argument npages is ignored and constant value '1' is used leaving out a possible overflow as the callers can legitimately be using npages > 1 for H_STUFF_TCE or H_PUT_TCE_INDIRECT cases. Fix this by accounting for 'npages', checking for arithmetic overflow, and verifying that the entire requested range (ioba - offset + npages) does not exceed the table capacity 'size'. Fixes: b1af23d836f8 ("KVM: PPC: iommu: Unify TCE checking") Reviewed-by: Ritesh Harjani (IBM) Tested-by: R Nageswara Sastry Signed-off-by: Shivaprasad G Bhat Signed-off-by: Gautam Menghani Signed-off-by: Madhavan Srinivasan Signed-off-by: Sasha Levin --- arch/powerpc/kernel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c index 370635107f1c6..e2b46dea8d904 100644 --- a/arch/powerpc/kernel/iommu.c +++ b/arch/powerpc/kernel/iommu.c @@ -999,7 +999,7 @@ int iommu_tce_check_ioba(unsigned long page_shift, if (ioba < offset) return -EINVAL; - if ((ioba + 1) > (offset + size)) + if ((ioba + npages < ioba) || (ioba - offset + npages > size)) return -EINVAL; return 0; -- 2.53.0