From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64509379C35; Wed, 30 Sep 2026 15:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783641; cv=none; b=kXz1w/E3KQfVrqjuziZrcXaLhkii53iInlK90uW9CCkJtovWIEWMi8fMJ8EACQ3cGKVVttVAotyuK/CEiEn2NVuxguhOBvzcF0Fq6bCrqDak3kUBaKwH2zrHUtetfmly9/6HSa3b9sOw6RKmc3ZPvtnkpYRA0R3F0aF1nHg1O6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783641; c=relaxed/simple; bh=+LPFHiJycWp0oi8N+aDfHaY38ig+rNLfWfJQwVe7qbQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JDn22xF1cF80HhiLy2+25hkKWz/nKATD+3S/nhu4GOjrqOT0DPe7SWPsrSU6j0pkDwXThdn4tRay+C3S8PIBBWxy+EJojFzooex24hNJm5LF4okyRPufje7QhuRI4iEftSYEk63QFZVgeTOEk5bNed0bNr+S+v92nuXuasdb1vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mU2G27oD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mU2G27oD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60DD81F000FF; Wed, 30 Sep 2026 15:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783636; bh=aEbKG5RM37KwEBtgp9xFwjlrZiLDdb+gWUmXW/iyR0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mU2G27oDMBiOj3m8ra3sf0H1GNmCpwmY4LcV0m3+Um1Ez8ash50eddhYGepDc1Of4 kEC6UwAbogn6DFts32jbPwuxAt8Tn0R9pLGai1u0+7mvYu3DCbTb85OTW7BoZTkH8N ecmqrmo0xXSebZPb8vftrT1Yc5blGt209Kl8sKM4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christian Lamparter , Shengzhuo Wei , Johannes Berg Subject: [PATCH 5.10 469/595] wifi: p54: require a full exp_if record in PDR_INTERFACE_LIST Date: Wed, 30 Sep 2026 17:26:02 +0200 Message-ID: <20260930152357.766749497@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shengzhuo Wei commit d8efd84f49379ed28624098821f80e992657d935 upstream. The PDR_INTERFACE_LIST loop only checks that the record start is within the entry before reading an entire struct exp_if from it. A truncated trailing record makes the if_id/variant reads cross the entry boundary into the heap beyond the EEPROM buffer (verified with a KASAN reproducer of the loop). The variant also feeds the synth front-end selection, so this is not only a leak. Advance only while a full record still fits in the entry. Fixes: eff1a59c48e3 ("[P54]: add mac80211-based driver for prism54 softmac hardware") Cc: stable@vger.kernel.org Acked-by: Christian Lamparter Assisted-by: GLM:5.3 Signed-off-by: Shengzhuo Wei Link: https://patch.msgid.link/20260831-p54-pda-validation-v2-2-dae566b388c8@cherr.cc Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/intersil/p54/eeprom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/wireless/intersil/p54/eeprom.c +++ b/drivers/net/wireless/intersil/p54/eeprom.c @@ -816,7 +816,8 @@ int p54_parse_eeprom(struct ieee80211_hw break; case PDR_INTERFACE_LIST: tmp = entry->data; - while ((u8 *)tmp < entry->data + data_len) { + while ((u8 *)tmp + sizeof(struct exp_if) <= + entry->data + data_len) { struct exp_if *exp_if = tmp; if (exp_if->if_id == cpu_to_le16(IF_ID_ISL39000)) synth = le16_to_cpu(exp_if->variant);