From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F9F4F4049; Wed, 30 Sep 2026 15:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783902; cv=none; b=Js2jssfmpXkYZcXZyUmFk8rmtjZ1mCTw56Fb7+lMVktvyxUxFAA8f1MaZiSDOaSssglKm87eTpQ/hL3dw66lZQQ6xGzapdj1nk59hvu7KH4Is+VYHylPNKZOFAEZCwBTdFQxnIf/eCaMxvFoFsYgzhuR+Fl4ejr+AYjJ9MV1hZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783902; c=relaxed/simple; bh=4wW9SdvjBzF6haFCcpQZ+/cF/OShdg9Yvk/cLr8hVBE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=suzaNZhzduxwylP6HSb6ezWNK+rJgTJ35ISPwKwnK9e5g85Ot7uubO7EQoK+cxew0qd593bgIxV2nHfuyHIun4vF5mPNCwjjsXRs80e9rQ0HjLg8naXdqDQ79e5Bz1K830sbRuDS/++rlhuPAQAwXHUU8IMU6zP4gO146US8GUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g0n2zAHt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g0n2zAHt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 815951F00893; Wed, 30 Sep 2026 15:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783898; bh=Cj4LD3WbeGRmS0laxseupIzSXwb8XKSuVXM7IPgS/gQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=g0n2zAHtwrys7z2N2sg9reC75TOfo9HT4VHl2KiLB1bOeY/wNEDhAypL/2iOvARKk ObPFrk9UIvDpDR1OBRSt0yKsBcHc62bRsqyQ/EvSrhJurYLcJVaYK+Xt92a3I/gpIs XQJ6K1ygU+X9gPch35wGOiw3ZcK+ECil7vFRFqJc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, VEGA , Zixuan Chai , Ren Wei , Eric Dumazet , Jakub Kicinski Subject: [PATCH 5.10 562/595] llc: reserve device headroom for allocated frames Date: Wed, 30 Sep 2026 17:27:35 +0200 Message-ID: <20260930152359.809398554@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zixuan Chai commit 72b5b9a28b996e09b8b5b944370c79851bb68f52 upstream. llc_alloc_frame() reserves link-layer headroom using the device type. This is insufficient for stacked Ethernet devices such as VLAN devices, where vlan_dev_hard_header() pushes a VLAN header before the lower device's Ethernet header. An LLC response on such a device can therefore underflow skb headroom in eth_header(). Use LL_RESERVED_SPACE() to account for the device's actual required headroom while preserving the existing LLC device-type check. Fixes: bf9ae5386bca ("llc: use dev_hard_header") Cc: stable@vger.kernel.org Reported-by: VEGA Signed-off-by: Zixuan Chai Signed-off-by: Ren Wei Reviewed-by: Eric Dumazet Link: https://patch.msgid.link/20260924012613.2533934-1-weir@nebusec.ai Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/llc/llc_sap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/net/llc/llc_sap.c +++ b/net/llc/llc_sap.c @@ -25,12 +25,12 @@ #include #include -static int llc_mac_header_len(unsigned short devtype) +static int llc_mac_header_len(struct net_device *dev) { - switch (devtype) { + switch (dev->type) { case ARPHRD_ETHER: case ARPHRD_LOOPBACK: - return sizeof(struct ethhdr); + return LL_RESERVED_SPACE(dev); } return 0; } @@ -51,7 +51,7 @@ struct sk_buff *llc_alloc_frame(struct s int hlen = type == LLC_PDU_TYPE_U ? 3 : 4; struct sk_buff *skb; - hlen += llc_mac_header_len(dev->type); + hlen += llc_mac_header_len(dev); skb = alloc_skb(hlen + data_size, GFP_ATOMIC); if (skb) {