From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13EB04E01FA; Wed, 30 Sep 2026 15:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783932; cv=none; b=UzpIt337sBH5YnFB+OxEZX/Sx5fwDwIpA8xTy5bS704vDvJnJugxlKYMc/Wt5oRvVvesThXepUskTn4+QLcR49ZXVhJlJOgx++Q44SYLZKLYb0arc9yCEbfA/zgSSJnGP0VoUuua966K4dLt0xGe+0ZdsGmJAgllJtyihPoiGXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783932; c=relaxed/simple; bh=nCf1TrGhM7IeHFPZtS1d1YVM6h/MAplBTsCOLpDSi14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=knj3ClzSlVCPc3JAjna1b9nbX+WKKguUO9Txh5l12OT07OVnr9sV1nppQXBkUEUvVBfe57yUrypdx3xnnQ9wqeZ448nn7gTEI8jVlBwGNgVctgrs0CTbk87OqNNNjCJ7QNSBlK7VK0NWUy+e536UIIszEiMiF7KdGP48sO8rYc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=slxb1kEs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="slxb1kEs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6E1B1F00893; Wed, 30 Sep 2026 15:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783926; bh=aEyCtB932LMZH8atzl/1gpwUQuKd3I2k08pDkGt+nLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=slxb1kEslDFoIRwqz0H++zOL1JAAHMdsePs2sMhcX/mQP/c3hluzfkM0k/gG6U8gA 12wiZCsXtTDyfs4B2EBgSZMRCqni/4iQcJY3TWRUJ4P44RvgEIcRKnb1YxjqwPYnJk YfjSOai2NT23YG2gjt5FFB+gae/IdyOEYJAWol9M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Tariq Toukan , Jakub Kicinski Subject: [PATCH 5.10 571/595] net/mlx5: Fix rev_entry reference leak in mlx5_tc_ct_shared_counter_get() Date: Wed, 30 Sep 2026 17:27:44 +0200 Message-ID: <20260930152400.007602838@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang commit 0bf6bb567f0edaa771e7dd208ef98da50e6a4485 upstream. When the reverse entry is found but its counter is already being released, refcount_inc_not_zero() fails and the reference taken by mlx5_tc_ct_entry_get() is never dropped before falling through to create_counter. Drop it so the reverse entry is not kept alive forever by a shared counter lookup that did not use it. Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both directions") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Reviewed-by: Tariq Toukan Link: https://patch.msgid.link/20260917113131.2149024-1-vulab@iscas.ac.cn Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c @@ -925,6 +925,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx spin_unlock_bh(&ct_priv->ht_lock); + if (rev_entry) + mlx5_tc_ct_entry_put(rev_entry); + create_counter: shared_counter = mlx5_tc_ct_counter_create(ct_priv);