From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B24A03AFCED; Wed, 30 Sep 2026 15:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783973; cv=none; b=II/hqDt5vdbApbOmmXtQAsW8ComAvGhDvPIV6uFuPatv+by+6SC5MHJrstt1omor6OXSY+7URBzcON9e3r6xLw9KReGLpWP4I7Z/Nxtv6/24uje/pI92A23JmLRBO1Np4HZI1ugcA4YNvi9QOZn9ON5im87lfmz/DdgqCsFZLYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783973; c=relaxed/simple; bh=c5FofId6z+lmU5/dqrWo/MrefiSPen894g0oxd77VFo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BSiCTms1TzPhCYsqdenhC5YlJQnL/aEo9OWKF4lgqlEODdl1H0LEJ2sZPQJhJOj+FNtsun0gennhm9t7K4lfn/XrlqUy0gSVV4x7efumd/s4RnpevjLNVteALKNVwbacodUGJGssFBhs5lNpBw5AvcL4D3RG2YTwGrQAq6cO8ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XaBXfFb2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XaBXfFb2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE2081F00893; Wed, 30 Sep 2026 15:59:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783966; bh=WrVmG2Lb+n7/W4iWb8OOBB6guK9/TLq6ODcHdeRd+TI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XaBXfFb2Pon6dLzSDQxNftUv5mqFWIPXNWoLF30xVisV51ZVNQz32PQcpIGTahG/+ to+7F92agFDCwD8dLR9U/Jda4+8YGrVnse9zEPnqcGqB1YFgI26fM0dvp4JZL5ydMG UEU3E8c0W63iHbMka3jAygErfphrT++ySZr9hsHg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aamir Ahmed , Simon Horman , David Heidelberg Subject: [PATCH 5.10 583/595] nfc: llcp: drop truncated I/RR/RNR PDUs in nfc_llcp_recv_hdlc() Date: Wed, 30 Sep 2026 17:27:56 +0200 Message-ID: <20260930152400.272814220@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aamir Ahmed commit 273f9d667cde649f8de9d72b1303cc2f4b658c50 upstream. nfc_llcp_recv_hdlc() reads the sequence byte skb->data[2], via nfc_llcp_ns()/nfc_llcp_nr(), before any length check. The receive path only guarantees the two-byte LLCP header -- __nfc_llcp_recv() checks it with pskb_may_pull() and nfc_llcp_recv_agf() admits two-byte inner PDUs -- so a two-byte I, RR or RNR PDU reads one byte of uninitialised skb tailroom. The byte becomes N(R)/N(S); a peer can already set those with a well-formed PDU, so this is acting on uninitialised memory, not new peer control. Guard the read with pskb_may_pull(), as commit 95674f506c63 ("nfc: llcp: reject PDUs shorter than the LLCP header") did for the two-byte header, so the sequence byte is present and linear before it is read. RR and RNR PDUs are LLCP_HEADER_SIZE + LLCP_SEQUENCE_SIZE bytes and an I PDU is longer, so no valid frame is rejected; a truncated PDU is malformed, so return without a DM reply. Fixes: d646960f7986 ("NFC: Initial LLCP support") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Aamir Ahmed Reviewed-by: Simon Horman Link: https://patch.msgid.link/AS8P251MB0001789BBF04B72745C7D96BC8BA2@AS8P251MB0001.EURP251.PROD.OUTLOOK.COM Signed-off-by: David Heidelberg Signed-off-by: Greg Kroah-Hartman --- net/nfc/llcp_core.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/nfc/llcp_core.c +++ b/net/nfc/llcp_core.c @@ -1108,6 +1108,9 @@ static void nfc_llcp_recv_hdlc(struct nf struct sock *sk; u8 dsap, ssap, ptype, ns, nr; + if (!pskb_may_pull(skb, LLCP_HEADER_SIZE + LLCP_SEQUENCE_SIZE)) + return; + ptype = nfc_llcp_ptype(skb); dsap = nfc_llcp_dsap(skb); ssap = nfc_llcp_ssap(skb);