From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78034FE2C9; Wed, 30 Sep 2026 15:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783980; cv=none; b=EY3Jsl6WhyDdNiij/UBwMNKq2O9tmK48K5744kufbAtUKnr/o+rAc7PxL6QuUuGbwpSCfkUHhrMb8FT/nWqis7/iKFGJXBfxHo+h3p5go/sQeDS1cMb7QQnVnwXfqzecH7Ko8yUcXZlfHazHdpT6rauy6umHgzkiKHguZTCdPek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783980; c=relaxed/simple; bh=7z/fc61XJVSnP78Qy09RMTx8UltnKrkw1pSOJvCA45o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sQr6/UcaUVS9YzmQJHUM3ORfRoXlj02fjfErmFPeptarKP7TFKW/i9jsZ064WaWTi/B7Yvfq4AH0Ufhvy/g/ERMIeS3aB/beJpyHQpE8rSKY04MuhXU/l0i7Lo1ig4gw0jE2xrit5U1hU2dqKeS8+jKeqjlIuh7PQhdp6rrzMmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zDd9JAhZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zDd9JAhZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69EF21F000FF; Wed, 30 Sep 2026 15:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783972; bh=rsA/6CmDR9McwgmF38WuHZBuNc7jDG3JtCBSHga0sAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zDd9JAhZZxNNNVlt2+O/Km3AtB8oXqPwjVDIlegkPyPTvwVZG9LirFAFZapV9uSxb /Z5o9n/FBcz2mTF7iYqV50l1SkI/Npr+KLcm6RX9oGCpqRn619H+bxDXbBzxqxYPUM QLEqe7oldAarV+IA1AqDUYc0ETL8YwK9L1vZEJps= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yehyeong Lee , Mike Christie , "Martin K. Petersen (Oracle)" Subject: [PATCH 5.10 585/595] scsi: libiscsi_tcp: Check the data direction of a Data-In PDU Date: Wed, 30 Sep 2026 17:27:58 +0200 Message-ID: <20260930152400.316222235@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yehyeong Lee commit bce07e2f37b5e4a427d36fd6b1c14067b27591db upstream. The Data-In branch of iscsi_tcp_hdr_dissect() resolves the ITT to a task and copies the PDU's data segment into that command's scatterlist without asking whether the command was reading. iscsi_tcp_r2t_rsp() in the same file does ask, and rejects an R2T for a command that is not DMA_TO_DEVICE. A target that answers a WRITE command's ITT with a Data-In therefore has the initiator write target-supplied bytes into the pages that write was about to send. Those are the caller's own pinned pages for an O_DIRECT write, and page cache pages for a buffered one. Observed against a test target that emits one 512-byte Data-In naming a 128 KB write's ITT, after the R2T for that write. With O_DIRECT the caller's buffer ends up holding 512 bytes of the target's data while pwrite() returns 131072. Buffered is quieter: pwrite() and fsync() both succeed, nothing is logged, and reading those blocks back returns the target's bytes out of the page cache without a command going on the wire. Check the direction before using the scatterlist, the way the R2T path already does. Cc: stable@vger.kernel.org Signed-off-by: Yehyeong Lee Reviewed-by: Mike Christie Link: https://patch.msgid.link/20260801133635.1986706-1-yhlee@isslab.korea.ac.kr Fixes: a081c13e39b5 ("[SCSI] iscsi_tcp: split module into lib and lld") Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/libiscsi_tcp.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/scsi/libiscsi_tcp.c +++ b/drivers/scsi/libiscsi_tcp.c @@ -491,6 +491,9 @@ static int iscsi_tcp_data_in(struct iscs int datasn = be32_to_cpu(rhdr->datasn); unsigned total_in_length = task->sc->sdb.length; + if (task->sc->sc_data_direction != DMA_FROM_DEVICE) + return ISCSI_ERR_PROTO; + /* * lib iscsi will update this in the completion handling if there * is status.