From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D39C51AFF9; Wed, 30 Sep 2026 17:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790788505; cv=none; b=Vxwt8i9+R9V1ZdVkOkWkyPsQtFvcFPnys/tfBqtiAERAuQft4JmOmxZNJIUQIIFqnIdwn361W8RD4sp91bDUaSvvLQBvWBkiGJH7kZyZJgpeeJkX8zjqTr0+Zh1W/jwdrClnQktKAOuD5bLRtEadqo1IzG4MMaYWPxJyJRGoNsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790788505; c=relaxed/simple; bh=VDWkt0NM7gc0RCpSi+zHGIildiEBqUVgtwFTY9D0Lv0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uu9Yi9PMt6/i5njYQMyQ510+MISejBK/327+WxKlp0CoB7VzeRBUUKiubbfFf1HEonDGoqRpJklLtgRzRQh1+aw0ywfS9UGV3E4Xa/uq733hALrdxA6u7eW8c4wFlLy1ntY7Rwr4Le4AR7T/K1IG4OK65VIuFRN1DxZutBkDDBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=B+dy2cw0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="B+dy2cw0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9052B1F000FF; Wed, 30 Sep 2026 17:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790788503; bh=eP//UIc+3MiCg4q6jxZFNDSDOWJXMWhooJNQoqjk4a8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=B+dy2cw0j9rIw+gYdMHACqSeWp9sauYh/ikcyheA8y2/8vOnDHqww40sKOMEygIhs 8o6UNL9STp7KMdq8LDzt1EfQlGudu4fryGMFRTagepavin8SMOqX1hEtkqQ6x9NA8d KCas+GL8sZcKU5WcAYxz+y387/gGi3H3ZC8RPXhs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Mark Brown , Sasha Levin Subject: [PATCH 6.12 147/877] ASoC: hdmi-codec: Report a change when the channel status moves Date: Wed, 30 Sep 2026 17:17:38 +0200 Message-ID: <20260930152417.895870058@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152414.738996857@linuxfoundation.org> References: <20260930152414.738996857@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An [ Upstream commit c17ae8c26eac16ad244daef44044d714f68a2ddc ] The put() callback of "IEC958 Playback Default" stores all 24 channel status bytes and then returns 0. The core notifies userspace only on a positive return, so a write that changes what the get() callback hands back is never announced, and a mixer holding the control open keeps showing the old value. Compare the stored bytes and return 1 when they move, the way snd_hda_spdif_default_put() does. The same shape is in img-spdif-out and uniperif_player. No board with this codec was to hand. The change is a comparison of driver state with no hardware behaviour in it, and mixer-test counts the missing notification as event_missing. Fixes: 7a8e1d44211e ("ASoC: hdmi-codec: Add iec958 controls") Signed-off-by: HyeongJun An Assisted-by: Claude:claude-opus-5 Link: https://patch.msgid.link/20260915092515.2638542-1-sammiee5311@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/hdmi-codec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index d9df29a26f4f2..0ffc649c6ad21 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -423,10 +423,14 @@ static int hdmi_codec_iec958_default_put(struct snd_kcontrol *kcontrol, struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); struct hdmi_codec_priv *hcp = snd_soc_component_get_drvdata(component); + if (!memcmp(hcp->iec_status, ucontrol->value.iec958.status, + sizeof(hcp->iec_status))) + return 0; + memcpy(hcp->iec_status, ucontrol->value.iec958.status, sizeof(hcp->iec_status)); - return 0; + return 1; } static int hdmi_codec_iec958_mask_get(struct snd_kcontrol *kcontrol, -- 2.53.0