From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 335A94DD3D1; Wed, 30 Sep 2026 16:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785111; cv=none; b=XIYMAWnZIHvAk3ou20OFvx4Mw0bqycaf9FNtNeexlEJGY0CGPHRTuB+Xt9jpSaqHk2LiW914chLt5EO8H5lpVtL85WRIlBnxEW8GTbJL6nfuhZX0IrhCPLC3c/uDHb5I3FhCxFuxlLUWMUNfWORjXgDEqB7A6CV5ZHDd8LCm314= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785111; c=relaxed/simple; bh=h+Jvlyqvap5c54KEdla40LpDBCEAjKrEnD0Q/F+DbMQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BhJOTpALgcc9eWu/8J8V39/6lZWRK7HmmSiQPxTeLPe2HKZieaUbquwLp59amfBi/1ULWFWzs9Hp8bQE4aragiOYc5e9ZvYPJuhP574WZn5L4RExTV1Zfe/KPL75w+1/bMNnABYR9dxi1WFm8qIIjxFSljxHnYsfQl+Xh30LqFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PKR+TMth; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PKR+TMth" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 064281F00898; Wed, 30 Sep 2026 16:18:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790785104; bh=xavjVOhk8ZoZs/71p4JhmRMCr33U530GFMbs+U98IMc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PKR+TMthVGFSuY+njuLLq4SeDNoqZ/8uebLrNzAH0cb5pchDi8iX7zrOp97sqvEF3 8032d7vXStqCHbupsJ0YRKhKuisoqwfALL4dV8T5iVgkxMCwM1wS2nGn01zeHqGKat +1+Xecpseo72lFdl4angLtarRSvzTWiU0OcN0LXY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Jay Vosburgh , Nikolay Aleksandrov , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 389/982] bonding: do not clear curr_active_slave prematurely when releasing all slaves Date: Wed, 30 Sep 2026 17:18:45 +0200 Message-ID: <20260930152425.162217328@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit af602c7aa5fedc9be3043244017aef4f26c96b70 ] When releasing all slaves during bond destruction (all == true), __bond_release_one() unconditionally clears bond->curr_active_slave to NULL in every iteration. If a backup slave is released before the active slave, bond_alb_deinit_slave() triggers rlb_teach_disabled_mac_on_primary(), which increments the active slave dev promiscuity counter and sets bond_info->primary_is_promisc = 1. Because bond->curr_active_slave was prematurely cleared to NULL when releasing the backup slave, the subsequent iteration releasing the active slave evaluates oldcurrent as NULL, so bond_change_active_slave(bond, NULL) is skipped. Consequently, bond_alb_handle_active_change() is never called to decrement the promiscuity counter, permanently leaking promiscuous mode on the physical device after bond teardown. When oldcurrent == slave, bond_change_active_slave(bond, NULL) already sets bond->curr_active_slave to NULL. We only need to avoid selecting a new active slave when all == true. Replace the if (all) branch with if (!all && oldcurrent == slave). Fixes: 0896341a44bf ("bonding: fix bond_release_all inconsistencies") Signed-off-by: Eric Dumazet Acked-by: Jay Vosburgh Reviewed-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20260831203042.164466-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index c4f640292bb59..5b8770118c4f0 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2485,9 +2485,7 @@ static int __bond_release_one(struct net_device *bond_dev, bond_alb_deinit_slave(bond, slave); } - if (all) { - RCU_INIT_POINTER(bond->curr_active_slave, NULL); - } else if (oldcurrent == slave) { + if (!all && oldcurrent == slave) { /* Note that we hold RTNL over this sequence, so there * is no concern that another slave add/remove event * will interfere. -- 2.53.0