From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BDC83515D1; Wed, 30 Sep 2026 16:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785510; cv=none; b=EhCru5OG4KkJzS22IU0NbczbD5c2FLstRrVxF8xXObHvsu6WUw5ySTkUOw9VlU034gw0oCu6I01Xbxq0nac5s03OAN2Uh5ACM94zim7s28oaBwpaY3mqZUUGE4ca0GeRxN9Sd46pP4f3ZNwFaXVUQzZhypM6gzuiczIG7xCjLyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785510; c=relaxed/simple; bh=zPa1RM0P9sLC5mMOsZ72gcAL5ttmauQYfv9UbkQr1+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IHem/ttwr7sKMa1ho3jCsTs7IPTf0ZMPAL99F9Pt4a/xf023IuaQzlaF7RE/WD7BZe98qu7DpylNLh38vtuEwJ9MecR9pRcvZPc6qt8ArCfHkyTeh60SZFRWDGcD4G4cLvUQoxPm0P6D3TVkZUFDj6UANkkl0t7OR8TbMa1z23I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KpfnZqz1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KpfnZqz1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E93201F00893; Wed, 30 Sep 2026 16:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790785503; bh=UNwVf7n+hiGCTa6Pm9HKFsGqA+3ERUuHO6Tn6gnHWAg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KpfnZqz11NwrNaCvhTXyzzobQmbT23Tv0Fec2P4qGDJvpRwz/kejZ6Hr+0/k+5Nwh V2YNrR3xGRWsIsg+NSnXmSyu76O4Sy4bJ3ZMQ1vJ+fD7qkTEHDwKRW3oOCPrE+TtHC qDuk6FqUVQXdwApjp0E3XpKh1T6V9S1mh5/jLjfE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cong Nguyen , Guenter Roeck Subject: [PATCH 6.1 531/982] hwmon: (applesmc) fix key backlight workqueue leak on register failure Date: Wed, 30 Sep 2026 17:21:07 +0200 Message-ID: <20260930152428.178985815@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Nguyen commit 5a0aacaa2d593d7582ecfe289529b937b6dc5d3c upstream. applesmc_create_key_backlight() allocates applesmc_led_wq before calling led_classdev_register(). When register fails, the error is returned to applesmc_init(), which jumps to out_light_sysfs and skips applesmc_release_key_backlight(), leaking the workqueue. Destroy the workqueue on the register failure path. The bug was introduced when the inline init block was refactored into a helper that returns errors directly, dropping the old out_light_wq unwind label. Fixes: 0b0b5dff8967 ("hwmon: (applesmc) Simplify feature sysfs handling") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen Link: https://patch.msgid.link/20260828105413.2401385-1-congnt264@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/applesmc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -1249,12 +1249,17 @@ static void applesmc_release_light_senso static int applesmc_create_key_backlight(void) { + int ret; + if (!smcreg.has_key_backlight) return 0; applesmc_led_wq = create_singlethread_workqueue("applesmc-led"); if (!applesmc_led_wq) return -ENOMEM; - return led_classdev_register(&pdev->dev, &applesmc_backlight); + ret = led_classdev_register(&pdev->dev, &applesmc_backlight); + if (ret) + destroy_workqueue(applesmc_led_wq); + return ret; } static void applesmc_release_key_backlight(void)