From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247E73624BF; Wed, 30 Sep 2026 16:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785911; cv=none; b=TXIOA8g4eg34/TZOiMkY4IcZYULQnpDqHw9PuDDV+92noRuH53hDe8+3hGnOREqfeFZDlWRPmEpWYimJ3KpSURjvM/U9XFtrZnoDDjcaZkILYq4PyCju7saJvXDqycge+ccrcL4LHnD9jhQn7Pd95zezfn/kC+4XrpL3J86/Pc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785911; c=relaxed/simple; bh=0vUUydjMW5i+/YUYayE5fC2YCGUvQIugb14R35mqTNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SRjtYWiv4OsVopmw/rE8DTPcoMZY3HwqYFzwU1Jj7Kodk+TGuZx87qxg7HWOvnK2/vPFhRKdADOBP7T0GhdPrODF378vxtz3LQab/Rz6580aWbq+zaT/69O7owNgen1TscTY8wfnzlX1Fm8fDO6p2IrFgMKTAQIK1H0qvIPBmuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E5JU2Y9m; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E5JU2Y9m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 461391F0089A; Wed, 30 Sep 2026 16:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790785909; bh=KzNzCZoEI5ZTIraS/9D8hY0YuN0BGS/HObrhkl9C8XI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=E5JU2Y9mCO7WDDDadTpYDuKPUoPYWdDNNxYfjlpSLZ+1eplKuViGgPi1i1c9faZp6 SUmJWwghSEm5dJw4vALAbfo51G24V569HMg3UXxjwO+9NBcjdVvzHQn1DglwL3lOcF qx/2cYmWCcB6creWLOIjKdMfug+5TcrSS4yEBbDU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baineng Shou , Frank Li , Vinod Koul , Sasha Levin Subject: [PATCH 6.1 674/982] dmaengine: mmp_pdma: fix wrong sg length in mmp_pdma_prep_slave_sg() Date: Wed, 30 Sep 2026 17:23:30 +0200 Message-ID: <20260930152431.240878673@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Baineng Shou [ Upstream commit 075bc7b1d3dde5ed43fbaabbc1a69f09b7fc3a47 ] In mmp_pdma_prep_slave_sg(), for_each_sg() iterates the scatterlist putting each entry into 'sg', but the entry length is read from 'sgl' (the list head) instead of 'sg' (the current entry): for_each_sg(sgl, sg, sg_len, i) { addr = sg_dma_address(sg); avail = sg_dma_len(sgl); /* should be 'sg' */ Consequently 'avail' is always the length of the first entry. For multi-sg lists this causes out-of-bounds reads when a later entry is shorter than the first, and silent data loss when it is longer. Single-sg or uniformly-sized lists happen to mask the issue. Fixes: c8acd6aa6bed3 ("dmaengine: mmp-pdma support") Signed-off-by: Baineng Shou Reviewed-by: Frank Li Link: https://patch.msgid.link/20260910021652.1296640-1-shoubaineng@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/mmp_pdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index bac4905c47db7..c51a296e3c1c1 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -542,7 +542,7 @@ mmp_pdma_prep_slave_sg(struct dma_chan *dchan, struct scatterlist *sgl, for_each_sg(sgl, sg, sg_len, i) { addr = sg_dma_address(sg); - avail = sg_dma_len(sgl); + avail = sg_dma_len(sg); do { len = min_t(size_t, avail, PDMA_MAX_DESC_BYTES); -- 2.53.0