From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F455509F0D; Wed, 30 Sep 2026 16:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790786697; cv=none; b=hvgoNACLEF9PZdJ0MAycc7JfsRWZJnnm3Y7SNzL+tfub87akYZ2TfADnyc62WMC4ym8Nhx1x1khkY15CFy/4K72fvxymH8jJuR71jbvanti7ceAzy4LXIohpuTCC8bXXPMhuC5L22eOL06werKx08GXxTY1SHgYsrpMpTedFWmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790786697; c=relaxed/simple; bh=3iJ1+8lN5A5MG4lRUf0qzCTtPm/A1xKZGXQgvlC+KXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hcCqcMkNLnHVtrUXM53qP7RL1EjC1ALwBgXxugbh5vl7g7zb6vDWtel8anqbhma/4TbiUnLIecpctCjJnBDpukDhvy1zFZqYqqD6DgJx03a5eyiiR4Q9Oe6HGPNEZkfaTZQl1UsWwViIXJcdTpF+TrusIfV4Y4/VKtWNfXCJ83Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1hJx3Thx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1hJx3Thx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88FE31F00893; Wed, 30 Sep 2026 16:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790786696; bh=1I6D9dvXFlnIbwa22/5CGH+Md7AVPWQX1N0vQK/Fb6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1hJx3ThxR8P90zCmyEDKefDGObWxx8m7g57rcnTJWetnAkZLI8ntUUA3pC9dr1UyA i9k0xt2ZLxICqCFsgJo+m/xYBIbkZy1yy/UcRgfZZ5oLBH3jGJe7aeJU7HV//ybTMZ 51qN3/zMkKt/YuIgQnebM0BeyhGZDnvS3J7bDWI4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vega , Zijie Huang , Ren Wei , Ido Schimmel , Jakub Kicinski Subject: [PATCH 6.1 953/982] net: arp: terminate device name before lookup Date: Wed, 30 Sep 2026 17:28:09 +0200 Message-ID: <20260930152437.204056189@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zijie Huang commit d8b6529e80bcb4fb8177121404cbb3377acaebd2 upstream. The ARP ioctl copies a user-provided struct arpreq into a stack object. Its arp_dev field may contain IFNAMSIZ bytes without a NUL terminator. Such input is passed to dev_get_by_name_rcu() or __dev_get_by_name(), where strcmp() can read past the end of the stack object when a matching alternative interface name exists. Terminate the field before the lookup to prevent the out-of-bounds read. Fixes: 36fbf1e52bd3 ("net: rtnetlink: add linkprop commands to add and delete alternative ifnames") Cc: stable@vger.kernel.org Reported-by: Vega Signed-off-by: Zijie Huang Signed-off-by: Ren Wei Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/fabf02a70787d17299e4b3153eadffaf20d154b3.1789910973.git.milkory@outlook.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv4/arp.c | 1 + 1 file changed, 1 insertion(+) --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -1222,6 +1222,7 @@ int arp_ioctl(struct net *net, unsigned err = copy_from_user(&r, arg, sizeof(struct arpreq)); if (err) return -EFAULT; + r.arp_dev[IFNAMSIZ - 1] = '\0'; break; default: return -EINVAL;