Re: [PATCH 1/4] RISC-V: Move common MPXY helper routines to arch/riscv

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: missing static inline on sbi_mpxy stub functions
--

commit ca97cea8474e30458386eddc230906510a535e88
Author: Anup Patel <anup.patel@oss.qualcomm.com>

RISC-V: Move common MPXY helper routines to arch/riscv
    
This commit moves the common MPXY helper routines and MPXY shared memory
management from the Linux SBI MPXY mailbox driver into arch/riscv. This
allows the kernel to directly perform SBI MPXY calls and share memory with
the mailbox driver when the Linux mailbox channel instance is unavailable.

> diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
> index 5725e0ca4dda3..c41e1af31a45f 100644
> --- a/arch/riscv/include/asm/sbi.h
> +++ b/arch/riscv/include/asm/sbi.h
[ ... ]
> @@ -685,7 +716,58 @@ int sbi_debug_console_read(char *bytes, unsigned int num_bytes);
>  
>  #else /* CONFIG_RISCV_SBI */
>  static inline int sbi_remote_fence_i(const struct cpumask *cpu_mask) { return -1; }
[ ... ]
> +static inline int sbi_mpxy_get_channel_ids(u32 channel_count, u32 *channel_ids)
> +{
> +	return -ENODEV;
> +}
> +
> +int sbi_mpxy_read_attrs(u32 channel_id, u32 base_attrid, u32 attr_count,
> +			u32 *attrs_buf)
> +{
> +	return -ENODEV;
> +}

[Severity: Low]
Does this omitted static inline modifier break compilation when
CONFIG_RISCV_SBI=n?

Without static inline on sbi_mpxy_read_attrs (and the other stub functions
below it), every C file including this header will generate a global symbol
for the function. This typically leads to multiple definition linker errors
across different translation units.

> +
> +int sbi_mpxy_write_attrs(u32 channel_id, u32 base_attrid, u32 attr_count,
> +			 u32 *attrs_buf)
> +{
> +	return -ENODEV;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930150213.799245-1-anup.patel@oss.qualcomm.com?part=1