From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Amirmohammad Eftekhar <amirmohammad.eftekhar@cispa.de>,
Sashiko Bot <sashiko-bot@kernel.org>
Subject: [PATCH v3 06/21] KVM: selftests: Drop unnecessary use of PRIu64 in nested TSC scaling test
Date: Wed, 30 Sep 2026 10:36:20 -0700 [thread overview]
Message-ID: <20260930173635.3362655-7-seanjc@google.com> (raw)
In-Reply-To: <20260930173635.3362655-1-seanjc@google.com>
Use a plain "lu" instead of "PRIu64" to print u64s in the nested TSC
scaling test, as KVM selftests are 64-bit only (and supporting 32-bit x86
selftest would be an absurdly large lift, for something absolutely no one
cares about).
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
.../kvm/x86/nested_tsc_scaling_test.c | 21 +++++++------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/tools/testing/selftests/kvm/x86/nested_tsc_scaling_test.c b/tools/testing/selftests/kvm/x86/nested_tsc_scaling_test.c
index 052ddd61482d..b8b2217b9efa 100644
--- a/tools/testing/selftests/kvm/x86/nested_tsc_scaling_test.c
+++ b/tools/testing/selftests/kvm/x86/nested_tsc_scaling_test.c
@@ -41,14 +41,9 @@ static void compare_tsc_freq(u64 actual, u64 expected)
thresh_low = expected - tolerance;
thresh_high = expected + tolerance;
- TEST_ASSERT(thresh_low < actual,
- "TSC freq is expected to be between %"PRIu64" and %"PRIu64
- " but it actually is %"PRIu64,
- thresh_low, thresh_high, actual);
- TEST_ASSERT(thresh_high > actual,
- "TSC freq is expected to be between %"PRIu64" and %"PRIu64
- " but it actually is %"PRIu64,
- thresh_low, thresh_high, actual);
+ TEST_ASSERT(thresh_low < actual && thresh_high > actual,
+ "TSC freq is '%lu', expected to be between %lu and %lu",
+ actual, thresh_low, thresh_high);
}
static void check_tsc_freq(int level)
@@ -166,7 +161,7 @@ int main(int argc, char *argv[])
* variable does not work.
*/
l1_scale_factor = (kvm_random_u32(&kvm_rng) % 9) + 2;
- printf("L1's scale down factor is: %"PRIu64"\n", l1_scale_factor);
+ printf("L1's scale down factor is: %lu\n", l1_scale_factor);
printf("L2's scale up factor is: %llu\n", L2_SCALE_FACTOR);
tsc_start = rdtsc();
@@ -174,7 +169,7 @@ int main(int argc, char *argv[])
tsc_end = rdtsc();
l0_tsc_freq = tsc_end - tsc_start;
- printf("real TSC frequency is around: %"PRIu64"\n", l0_tsc_freq);
+ printf("real TSC frequency is around: %lu\n", l0_tsc_freq);
vm = vm_create_with_one_vcpu(&vcpu, l1_guest_code);
@@ -207,16 +202,14 @@ int main(int argc, char *argv[])
break;
case UCHECK_L1:
l1_tsc_freq = uc.args[1];
- printf("L1's TSC frequency is around: %"PRIu64
- "\n", l1_tsc_freq);
+ printf("L1's TSC frequency is around: %lu\n", l1_tsc_freq);
compare_tsc_freq(l1_tsc_freq,
l0_tsc_freq / l1_scale_factor);
break;
case UCHECK_L2:
l2_tsc_freq = uc.args[1];
- printf("L2's TSC frequency is around: %"PRIu64
- "\n", l2_tsc_freq);
+ printf("L2's TSC frequency is around: %lu\n", l2_tsc_freq);
compare_tsc_freq(l2_tsc_freq,
l1_tsc_freq * L2_SCALE_FACTOR);
--
2.56.0.rc1.315.gc6ed9934b7-goog
next prev parent reply other threads:[~2026-09-30 17:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 17:36 [PATCH v3 00/21] KVM: x86: Fix nested TSC scaling edge cases Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 01/21] KVM: x86: Saturate L2's TSC frequency if it exceeds hardware supports Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 02/21] KVM: SVM: Fallback to the default TSC ratio if KVM tries to use a bad multiplier Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 03/21] KVM: x86: Allow userspace to set KVM's max supported guest TSC frequency Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 04/21] KVM: selftests: Use KVM's pRNG to randomize L1's TSC ratio in TSC scaling test Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 05/21] KVM: selftests: Drop redundant VMWRITE of TSC_MULTIPLIER_HIGH Sean Christopherson
2026-09-30 17:36 ` Sean Christopherson [this message]
2026-09-30 17:36 ` [PATCH v3 07/21] KVM: selftests: Randomize L2's scale factor in nested TSC scaling test Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 08/21] KVM: selftests: Rename TSC freq checkers " Sean Christopherson
2026-09-30 17:45 ` sashiko-bot
2026-09-30 18:00 ` Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 09/21] KVM: selftests: Extract guts of nested TSC scaling test to helper function Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 10/21] KVM: selftests: Track L2 multiplier, not scale-up factor, in nested TSC test Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 11/21] KVM: selftests: Print out the failing L{0,1,2} level in nested TSC scaling test Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 12/21] KVM: selftests: Allow +/- 1 tolerance if expected TSC frequency is <100 Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 13/21] KVM: selftests: Use KVM's reported TSC KHz as L0's frequency (sanity checked) Sean Christopherson
2026-09-30 17:52 ` sashiko-bot
2026-09-30 18:08 ` Sean Christopherson
2026-10-02 23:43 ` Jim Mattson
2026-10-06 5:37 ` Sean Christopherson
2026-10-06 21:57 ` Jim Mattson
2026-10-07 6:04 ` Sean Christopherson
2026-10-07 17:25 ` Jim Mattson
2026-09-30 17:36 ` [PATCH v3 14/21] KVM: selftests: Explicitly pass TSC frequencies to guts of TSC scaling test Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 15/21] KVM: selftests: Sanity check KVM's default TSC freq in nested " Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 16/21] KVM: selftests: Test L1 "up" and L2 "down" " Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 17/21] KVM: selftests: Verify that KVM saturates L2 TSC freq on {under,over}flow Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 18/21] KVM: selftests: Test non-zero TSC offset on SVM in nested TSC scaling test Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 19/21] KVM: selftests: Randomize L2's TSC offset in the " Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 20/21] KVM: selftests: Use GUEST_SYNC2() in " Sean Christopherson
2026-09-30 17:36 ` [PATCH v3 21/21] KVM: selftests: Spell out UCALL in nested TSC scaling test's enums Sean Christopherson
2026-10-02 21:07 ` [PATCH v3 00/21] KVM: x86: Fix nested TSC scaling edge cases Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930173635.3362655-7-seanjc@google.com \
--to=seanjc@google.com \
--cc=amirmohammad.eftekhar@cispa.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.