All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	maz@kernel.org, robin.murphy@arm.com, saravanak@kernel.org,
	will@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] of: Fix phandle_node reference leak in of_map_id()
Date: Wed, 30 Sep 2026 16:12:28 -0500	[thread overview]
Message-ID: <20260930211228.GA271514-robh@kernel.org> (raw)
In-Reply-To: <20260917124039.2151588-1-vulab@iscas.ac.cn>

On Thu, Sep 17, 2026 at 12:40:39PM +0000, Wentao Liang wrote:
> of_find_node_by_phandle() returns a node with an elevated reference
> count. When the caller passes target == NULL it only wants the
> translated ID, so that reference is never handed over and must be
> dropped before returning success.
> 
> Fixes: 987068fcbdb7 ("of/irq: Break out msi-map lookup (again)")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/of/base.c | 2 ++
>  1 file changed, 2 insertions(+)

This doesn't apply on current code.

Rob

      reply	other threads:[~2026-09-30 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 12:40 [PATCH] of: Fix phandle_node reference leak in of_map_id() Wentao Liang
2026-09-30 21:12 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930211228.GA271514-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=saravanak@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.