From: Omar Ramadan <omar@blockcast.net>
To: netdev-bot+sinfo@kernel.org
Cc: Taehee Yoo <ap420073@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] amt: pull the AMT header behind the transport header in amt_parse_type()
Date: Thu, 1 Oct 2026 01:27:28 +0300 [thread overview]
Message-ID: <20260930222733.47563-1-omar@blockcast.net> (raw)
In-Reply-To: <179061960357.31693.937915571809434718@kernel.org>
Found by code inspection: an LLM-assisted review of drivers/net/amt.c
while I was working on an IPv6 outer transport for amt, whose ICMPv6
errors would go through amt_err_lookup() the same way.
It has not been triggered. I have no reproducer; it comes from reading
the code. It needs an ICMP error reaching a gateway's encapsulation
socket that quotes only the IP and UDP headers of a Request, so that
amt_parse_type() reads the AMT header past the data it pulled.
Testing: W=1 build with CONFIG_IPV6=y and =n, and
tools/testing/selftests/net/amt.sh passes with the patch applied, but
no test injects such an ICMP error, so nothing exercises the changed
path.
next prev parent reply other threads:[~2026-09-30 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 18:15 [PATCH net] amt: pull the AMT header behind the transport header in amt_parse_type() Omar Ramadan
2026-09-28 18:20 ` netdev-bot+sinfo
2026-09-30 22:27 ` Omar Ramadan [this message]
2026-10-01 11:07 ` Paolo Abeni
2026-10-01 12:51 ` Omar Ramadan
2026-10-01 7:15 ` Eric Dumazet
2026-10-01 7:16 ` Eric Dumazet
2026-10-01 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930222733.47563-1-omar@blockcast.net \
--to=omar@blockcast.net \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.