From: Andrew Davis <afd@ti.com>
To: Tony Lindgren <tony@atomide.com>, Vignesh R <vigneshr@ti.com>,
"Andreas Kemnade" <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
"Roger Quadros" <rogerq@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: [uL RFC PATCH v3 3/8] i2c: omap: Use devm_pm_runtime_enable() helper
Date: Wed, 30 Sep 2026 17:34:58 -0500 [thread overview]
Message-ID: <20260930223503.616776-4-afd@ti.com> (raw)
In-Reply-To: <20260930223503.616776-1-afd@ti.com>
Use device life-cycle managed runtime enable function to simplify probe
and exit paths. It will call pm_runtime_dont_use_autosuspend() for us.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index eb20b789f3a1d..b551fd8e2dbf6 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1376,13 +1376,13 @@ omap_i2c_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, omap);
init_completion(&omap->cmd_complete);
- pm_runtime_enable(omap->dev);
+ devm_pm_runtime_enable(omap->dev);
pm_runtime_set_autosuspend_delay(omap->dev, OMAP_I2C_PM_TIMEOUT);
pm_runtime_use_autosuspend(omap->dev);
r = pm_runtime_resume_and_get(omap->dev);
if (r < 0)
- goto err_disable_pm;
+ return r;
/*
* Read the Rev hi bit-[15:14] ie scheme this is 1 indicates ver2.
@@ -1496,9 +1496,6 @@ omap_i2c_probe(struct platform_device *pdev)
omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0);
err_put_pm:
pm_runtime_put_sync(omap->dev);
-err_disable_pm:
- pm_runtime_dont_use_autosuspend(omap->dev);
- pm_runtime_disable(&pdev->dev);
return r;
}
@@ -1519,9 +1516,7 @@ static void omap_i2c_remove(struct platform_device *pdev)
else
omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0);
- pm_runtime_dont_use_autosuspend(&pdev->dev);
pm_runtime_put_sync(&pdev->dev);
- pm_runtime_disable(&pdev->dev);
}
static int omap_i2c_runtime_suspend(struct device *dev)
--
2.39.2
next prev parent reply other threads:[~2026-09-30 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 22:34 [uL RFC PATCH v3 0/8] OMAP I2C driver cleanups Andrew Davis
2026-09-30 22:34 ` [uL RFC PATCH v3 1/8] i2c: omap: Drop bit shift for I2C register addresses Andrew Davis
2026-09-30 22:34 ` [uL RFC PATCH v3 2/8] i2c: omap: Remove unused is_rdr and is_xdr variables Andrew Davis
2026-09-30 22:34 ` Andrew Davis [this message]
2026-09-30 22:34 ` [uL RFC PATCH v3 4/8] i2c: omap: Combine event flags register definitions Andrew Davis
2026-09-30 22:35 ` [uL RFC PATCH v3 5/8] i2c: omap: Use bool for flag values Andrew Davis
2026-09-30 22:35 ` [uL RFC PATCH v3 6/8] i2c: omap: Make reset bit name match register name Andrew Davis
2026-09-30 22:35 ` [uL RFC PATCH v3 7/8] i2c: omap: Switch to using BIT and GENMASK Andrew Davis
2026-09-30 22:35 ` [uL RFC PATCH v3 8/8] i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions Andrew Davis
2026-09-30 22:37 ` [uL RFC PATCH v3 0/8] OMAP I2C driver cleanups Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930223503.616776-4-afd@ti.com \
--to=afd@ti.com \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.