All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: SJ Park <sj@kernel.org>
Cc: stable@vger.kernel.org, damon@lists.linux.dev,
	Liew Rui Yan <aethernet65535@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 6.18.y 1/2] mm/damon/core: allow esz to be set to zero
Date: Wed, 30 Sep 2026 06:34:35 +0200	[thread overview]
Message-ID: <2026093025-cadet-late-bf00@gregkh> (raw)
In-Reply-To: <20260929191319.10187-1-sj@kernel.org>

On Tue, Sep 29, 2026 at 12:13:19PM -0700, SJ Park wrote:
> Hello stable team,
> 
> 
> Please don't apply this patch.
> 
> On Tue, 29 Sep 2026 10:44:55 -0700 SJ Park <sj@kernel.org> wrote:
> 
> > From: Liew Rui Yan <aethernet65535@gmail.com>
> > 
> > When the temporal quota goal tuner determines that the goal has been
> > achieved (score >= 10000), it sets esz_bp to zero so that the esz becomes
> > zero.  However, damos_set_effective_quota() clamps the esz to
> > min_region_sz when quota->ms is set.
> > 
> > This is a minor issue, the main problem is that it doesn't match the
> > description in the documentation, which state that if the goal has already
> > been [over-]achieved, the quota will be set to zero.
> > 
> > Fix this by set quota (esz) as minimum as possible.
> > 
> > Link: https://lore.kernel.org/20260908135413.97570-1-sj@kernel.org
> > Fixes: 8bbde987c2b8 ("mm/damon/core: disallow time-quota setting zero esz")
> 
> The problem happens only when there is temporal tuner.  Temporal tuner is a
> feature that introduced in 7.1.  Hence <7.1 stable kernels don't have the
> temporal tuner, and this patch shouldn't be applied.

SHould we skip patch 2/2 here too?

  reply	other threads:[~2026-09-30  4:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 17:44 [PATCH 6.18.y 1/2] mm/damon/core: allow esz to be set to zero SJ Park
2026-09-29 17:44 ` [PATCH 6.18.y 2/2] mm/damon/core: fix unconditionally skip last region SJ Park
2026-09-29 17:55   ` sashiko-bot
2026-09-29 17:59 ` [PATCH 6.18.y 1/2] mm/damon/core: allow esz to be set to zero sashiko-bot
2026-09-29 19:13 ` SJ Park
2026-09-30  4:34   ` Greg KH [this message]
2026-09-30  8:09     ` SJ Park
2026-09-30 12:29       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026093025-cadet-late-bf00@gregkh \
    --to=greg@kroah.com \
    --cc=aethernet65535@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=sj@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.