From: sashiko-bot@kernel.org
To: "Manush Prajwal" <manushprajwal555@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: lp50xx: use scoped loop to fix fwnode reference leak in lp50xx_probe_dt()
Date: Thu, 01 Oct 2026 04:52:26 +0000 [thread overview]
Message-ID: <20261001045227.32DED1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <6abde533.1f5d5c08.1fd03.f4e7@mx.google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: commit message description is not capitalized
--
commit 0f74bc379bcec72de3189968214e524ff15885d0
Author: Manush Prajwal <manushprajwal555@gmail.com>
leds: lp50xx: use scoped loop to fix fwnode reference leak in lp50xx_probe_dt()
This commit fixes an fwnode reference leak in lp50xx_probe_dt() by using
fwnode_for_each_child_node_scoped(). This automatically handles reference
counting for the child node across all exit paths, eliminating the need for
manual cleanup on failure.
> leds: lp50xx: use scoped loop to fix fwnode reference leak in lp50xx_probe_dt()
[Severity: Low]
This isn't a bug, but does the commit subject violate the subsystem's naming
conventions? The LED subsystem guidelines require the description following
the prefix to be capitalized (e.g., "leds: lp50xx: Use scoped loop...").
--
Sashiko AI review · https://sashiko.dev/#/patchset/6abde533.1f5d5c08.1fd03.f4e7@mx.google.com?part=1
next prev parent reply other threads:[~2026-10-01 4:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 4:44 [PATCH] leds: lp50xx: use scoped loop to fix fwnode reference leak in lp50xx_probe_dt() Manush Prajwal
2026-10-01 4:52 ` sashiko-bot [this message]
2026-10-02 12:40 ` Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001045227.32DED1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=manushprajwal555@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.