Re: [PATCH] rtc: nct3018y: report chassis intrusion through hwmon

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

On 01/10/2026 05:48:21+0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] rtc: nct3018y: hwmon device registration violates layering guidelines
> --
> 
> commit 12bf4b0b27866f7565ebcc7b10db8faf4943fb10
> Author: Eric Liu <liuer@nvidia.com>
> 
> rtc: nct3018y: report chassis intrusion through hwmon
> 
> This patch adds an hwmon intrusion alarm for the chip's chassis intrusion
> latch. Reading it says whether the chassis has been opened since the latch was
> last cleared; writing 0 clears it and re-arms.
> 
> > diff --git a/drivers/rtc/rtc-nct3018y.c b/drivers/rtc/rtc-nct3018y.c
> > index 2f7ad57057a4b..194ba077363aa 100644
> > --- a/drivers/rtc/rtc-nct3018y.c
> > +++ b/drivers/rtc/rtc-nct3018y.c
> 
> [ ... ]
> 
> > @@ -491,6 +494,95 @@ static const struct rtc_class_ops nct3018y_rtc_ops = {
> >  	.ioctl		= nct3018y_ioctl,
> >  };
> >  
> > +#if IS_REACHABLE(CONFIG_HWMON)
> 
> [ ... ]
> 
> > +static void nct3018y_hwmon_register(struct nct3018y *nct3018y)
> > +{
> > +	struct device *dev;
> > +
> > +	dev = devm_hwmon_device_register_with_info(&nct3018y->client->dev,
> > +						   "nct3018y", nct3018y,
> > +						   &nct3018y_hwmon_chip_info,
> > +						   NULL);
> [Severity: Medium]
> Does this violate the hardware monitoring subsystem architecture rules?
> 
> Registering a hardware monitoring device directly from within
> nct3018y_hwmon_register() in drivers/rtc/rtc-nct3018y.c bypasses hwmon
> maintainer review and pollutes the RTC driver with secondary hardware
> monitoring code.
> 
> Could this hwmon functionality be decoupled via an auxiliary device driver
> located in the hwmon subsystem directory instead?

While this is not an issue to register the hwmon driver from rtc, this
still needs a review from the hwmon maintainers.

> 
> > +	if (IS_ERR(dev))
> > +		dev_warn(&nct3018y->client->dev,
> > +			 "unable to register hwmon device %ld\n", PTR_ERR(dev));
> > +}
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261001054108.3346426-1-liuer@nvidia.com?part=1

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com