Re: [PATCH v11 05/19] dmaengine: ti: k3-udma: move descriptor management to k3-udma-common.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: ti: missing <linux/slab.h> include in k3-udma-common.c
--

commit 0bc54c526536ebf3ec79e663e240494d3391a71a
Author: Sai Sree Kartheek Adivi <s-adivi@ti.com>

dmaengine: ti: k3-udma: move descriptor management to k3-udma-common.c

This commit refactors the K3 UDMA driver by moving descriptor handling logic
from k3-udma.c to a new k3-udma-common.c library. This change prepares the
driver for supporting the new K3 UDMA v2 variant.

> diff --git a/drivers/dma/ti/k3-udma-common.c b/drivers/dma/ti/k3-udma-common.c
> new file mode 100644
> index 0000000000000..9b7ae758bdc90
> --- /dev/null
> +++ b/drivers/dma/ti/k3-udma-common.c

[ ... ]

> +static struct udma_desc *udma_alloc_tr_desc(struct udma_chan *uc,
> +				     size_t tr_size, int tr_count,
> +				     enum dma_transfer_direction dir)
> +{

[ ... ]

> +	/* We have only one descriptor containing multiple TRs */
> +	d = kzalloc(sizeof(*d) + sizeof(d->hwdesc[0]), GFP_NOWAIT);

[Severity: Low]
Could we add an explicit include for <linux/slab.h> in this new file?

The file k3-udma-common.c explicitly calls kzalloc(), kzalloc_flex(), and
kfree(), but <linux/slab.h> is not explicitly included. This can cause build
failures on configurations where the header isn't implicitly pulled in.

> +	if (!d)
> +		return NULL;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001084105.1692228-1-s-adivi@ti.com?part=5