Re: [PATCH 1/4] dt-bindings: input: touchscreen: hynitron,cst816x: configure axes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect use of additionalProperties with $ref
--

commit 0f12b787d0fbdb216a571a789ed3dfa0d0a368db
Author: Daniel Golle <daniel@makrotopia.org>

dt-bindings: input: touchscreen: hynitron,cst816x: configure axes

This commit references touchscreen.yaml and allows the properties
touchscreen-inverted-x, touchscreen-inverted-y, and touchscreen-swapped-x-y.

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
> --- a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml
> @@ -36,6 +36,10 @@ properties:
>        - description: Slide right gesture
>        - description: Long press gesture
>  
> +  touchscreen-inverted-x: true
> +  touchscreen-inverted-y: true
> +  touchscreen-swapped-x-y: true

[Severity: Low]
Looking at the properties block in
Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816x.yaml, are
these redundant definitions a direct workaround for the improperly configured
additionalProperties keyword below?

> +
>  required:
>    - compatible
>    - reg
> @@ -43,6 +47,9 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:
> +  - $ref: touchscreen.yaml#

[Severity: Low]
Looking at the allOf block in the same file, does the combination of
additionalProperties: false and a $ref create a constraint collision that
restricts validation exclusively to locally defined properties, breaking proper
schema inheritance?

If a valid generic touchscreen property (e.g., touchscreen-size-x) not
explicitly listed in the local schema is defined, running make dtbs_check
will incorrectly reject it. Would changing additionalProperties: false to
unevaluatedProperties: false address this when inheriting from another schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/d18629ede3f2fd5a08d0cbdaf82f4254e89500ed.1790851590.git.daniel@makrotopia.org?part=1