Re: [PATCH 3/5] net: phy: mxl-gpy: release MxL86211C Super Isolate

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net: phy: missing stabilization delay after Super Isolate release
--

commit 696acbb2e810bf2a7d2b0db83b48e8096bfe7dcf
Author: Robert Marko <robert.marko@sartura.hr>

net: phy: mxl-gpy: release MxL86211C Super Isolate

The commit clears the VSPEC1_PM_CTRL_SI bit in mxl86211c_probe() to release
the MxL86211C PHY from Super Isolate mode. This is done after registering
the MDIO voltage regulator and before generic initialization.

> diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
> index 4cbbfae046317..790075632fc3f 100644
> --- a/drivers/net/phy/mxl-gpy.c
> +++ b/drivers/net/phy/mxl-gpy.c
[ ... ]
> @@ -459,7 +456,15 @@ static int mxl86211c_probe(struct phy_device *phydev)
>  		return PTR_ERR(rdev);
>  	}
>  
> -	return 0;
> +	ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1, VSPEC1_PM_CTRL,
> +			     VSPEC1_PM_CTRL_SI,
> +			     0);
> +	if (ret)
> +		return ret;
> +
> +	ret = gpy_probe(phydev);

[Severity: Medium]
Will the hardware be fully initialized and ready to respond to MDIO reads
immediately after de-asserting the Super Isolate bit?

The commit message mentions that the PHY is halted after reset until
software releases it. If it behaves like a device coming out of reset, does
it require a stabilization delay (e.g., using usleep_range()) before
gpy_probe() reads the firmware version via phy_read()?

Without a delay, could this result in read failures or uninitialized
hardware responses if the PHY requires time to boot its firmware?

> +
> +	return ret;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930122305.293686-1-robert.marko@sartura.hr?part=3