Re: [PATCH 2/2] drm/kms-helper: Remove struct drm_simple_display_pipe and helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] drm/kms-helper: build breakage in imx-lcdc due to removed drm_simple_display_pipe
- [Low] doc: spelling mistake introduced in fbtft/TODO
--

commit d4d7a38057f45dc5b1cce9536154c93423caeae1
Author: Thomas Zimmermann <tzimmermann@suse.de>
Subject: drm/kms-helper: Remove struct drm_simple_display_pipe and helpers

This commit removes the struct drm_simple_display_pipe data type and its
associated helper functions from the DRM subsystem. It cleans up the
remaining TODO items related to simple-pipe, under the premise that all
drivers have been updated to use regular atomic helpers.

>     There are no drivers using struct drm_simple_display_pipe. Remove
>     the data type and all related helpers.

[Severity: Low]
Is this description accurate?

The imx-lcdc driver appears to still use struct drm_simple_display_pipe and
its helper functions. Compiling with CONFIG_DRM_IMX_LCDC enabled will result
in a build failure because the driver still relies on this structure in its
device setup:

drivers/gpu/drm/imx/lcdc/imx-lcdc.c:imx_lcdc() {
	...
	struct drm_simple_display_pipe pipe;
	...
}

As well as during initialization:

drivers/gpu/drm/imx/lcdc/imx-lcdc.c:imx_lcdc_probe() {
	...
	ret = drm_simple_display_pipe_init(drm, &lcdc->pipe,
					   &imx_lcdc_pipe_funcs,
					   imx_lcdc_formats,
					   ARRAY_SIZE(imx_lcdc_formats), NULL, NULL);
	...
}

> diff --git a/drivers/staging/fbtft/TODO b/drivers/staging/fbtft/TODO
> index e72a08bf221cf..72df3ea3a52ce 100644
> --- a/drivers/staging/fbtft/TODO
> +++ b/drivers/staging/fbtft/TODO
> @@ -1,3 +1,3 @@
> -* convert all these over to drm_simple_display_pipe and submit for inclusion
> -  into the DRM subsystem under drivers/gpu/drm - fbdev doesn't take any new
> -  drivers anymore.
> +* convert all these over to DRM and submit thme for inclusion into
                                              ^^^^

[Severity: Low]
This isn't a bug, but there is a typo here (thme instead of them).

> +  the DRM subsystem under drivers/gpu/drm - fbdev doesn't take any
> +  new drivers anymore.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001133736.802604-1-tzimmermann@suse.de?part=2