From: Simon Horman <horms@kernel.org>
To: Xinsheng Zhu <xinsheng.zhu.ny@gmail.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: usb: asix: remove redundant PHY address short-read check
Date: Thu, 1 Oct 2026 14:57:45 +0100 [thread overview]
Message-ID: <20261001135745.GF13925@horms.kernel.org> (raw)
In-Reply-To: <20260928192119.73351-1-xinsheng.zhu.ny@gmail.com>
On Mon, Sep 28, 2026 at 03:21:19PM -0400, Xinsheng Zhu wrote:
> Short-read handling was added to asix_read_cmd() by commit
> 920a9fa27e78 ("net: asix: add proper error handling of usb read errors").
> The helper converts short reads to -ENODATA while preserving negative
> errors from the underlying USB read operation.
>
> Remove the redundant short-read check in asix_read_phy_addr()
> and its unreachable -EIO assignment. The existing negative-return check
> handles both short reads and underlying USB read errors.
>
> Signed-off-by: Xinsheng Zhu <xinsheng.zhu.ny@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-01 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 19:21 [PATCH net-next] net: usb: asix: remove redundant PHY address short-read check Xinsheng Zhu
2026-10-01 13:57 ` Simon Horman [this message]
2026-10-02 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001135745.GF13925@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xinsheng.zhu.ny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.