From: sashiko-bot@kernel.org
To: "Komal Bajaj" <komal.bajaj@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] arm64: dts: qcom: shikra-evk: Add GPIO expanders
Date: Thu, 01 Oct 2026 13:58:38 +0000 [thread overview]
Message-ID: <20261001135839.459FD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001-shikra-gpio-expander-v3-1-d30c1e8067db@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: incorrect compatible strings for I2C GPIO expanders
--
commit 1d7a662c567d09ded1460a7741dd86e406ccdb82
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
arm64: dts: qcom: shikra-evk: Add GPIO expanders
This commit adds the EVK GPIO expander definitions on the I2C3 bus.
It describes the TCA9538 and TCA9539 expanders used by EVK boards.
> diff --git a/arch/arm64/boot/dts/qcom/shikra-evk.dtsi b/arch/arm64/boot/dts/qcom/shikra-evk.dtsi
> index 7fbd6d1de19ad..1c49cb52ce12b 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-evk.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra-evk.dtsi
[ ... ]
> +&i2c3 {
> + status = "okay";
> +
> + expander0: gpio@20 {
> + compatible = "ti,tca9539";
> + reg = <0x20>;
[Severity: Low]
Is this the correct compatible string for the hardware present at this I2C
address?
The ti,tca9539 IC is hardcoded to respond at 0x74-0x77 and cannot physically
respond at I2C address 0x20. Are the chips present at 0x20 and 0x21 actually
TCA9535 or PCA9535 ICs, which use the 0x20-0x27 address range?
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + expander1: gpio@21 {
> + compatible = "ti,tca9539";
> + reg = <0x21>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + expander2: gpio@38 {
> + compatible = "ti,tca9538";
> + reg = <0x38>;
[Severity: Low]
Is this compatible string accurate for this address?
The ti,tca9538 IC is hardcoded to the 0x70-0x73 range and cannot respond at
0x38. Are the ICs located at 0x38 and 0x3c actually TCA9554 or PCA9554
expanders?
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-shikra-gpio-expander-v3-1-d30c1e8067db@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-10-01 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 13:49 [PATCH v3] arm64: dts: qcom: shikra-evk: Add GPIO expanders Komal Bajaj
2026-10-01 13:58 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001135839.459FD1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.