All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "James Clark" <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/2] coresight: Retry failed HW_ID writes
Date: Thu, 01 Oct 2026 14:26:53 +0000	[thread overview]
Message-ID: <20261001142654.345AF1F00898@smtp.kernel.org> (raw)
In-Reply-To: <20261001-james-cs-retry-hw_id-v1-2-4d45ab46cde7@linaro.org>

> Don't set the aux_hwid_done bit when writes fail so that it can be
> retried later if the ring buffer was full. Add a second attempt on stop,
> which will always succeed if the stop's AUX output also has enough space
> to be written. If there is no AUX record then there will be no decoding,
> so the missing HW_ID isn't important.
> 
> Signed-off-by: James Clark <james.clark@linaro.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-james-cs-retry-hw_id-v1-0-4d45ab46cde7@linaro.org?part=2


      reply	other threads:[~2026-10-01 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 14:21 [PATCH 0/2] coresight: Retry failed HW_ID writes James Clark
2026-10-01 14:21 ` [PATCH 1/2] perf/core: Return errors from perf_report_aux_output_id() James Clark
2026-10-01 14:26   ` sashiko-bot
2026-10-05 15:46   ` Suzuki K Poulose
2026-10-01 14:21 ` [PATCH 2/2] coresight: Retry failed HW_ID writes James Clark
2026-10-01 14:26   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001142654.345AF1F00898@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=james.clark@linaro.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.