All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kathiravan Thirumoorthy" <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332
Date: Thu, 01 Oct 2026 15:18:32 +0000	[thread overview]
Message-ID: <20261001151833.6C9C91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001-imem_restart_reason-v1-1-79f516906010@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: sram: compatible strings not sorted alphabetically
--

commit be343d0f902aa8be0dcbad3550c7127521779814
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332

This commit documents the compatible strings for the IMEM found in the 
Qualcomm IPQ9574 and IPQ5332 SoCs.

> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
> index 6ee0b14647222..d65696885e6a5 100644
> --- a/Documentation/devicetree/bindings/sram/sram.yaml
> +++ b/Documentation/devicetree/bindings/sram/sram.yaml
> @@ -37,6 +37,8 @@ properties:
>          - qcom,eliza-imem
>          - qcom,glymur-imem
>          - qcom,hawi-imem
> +        - qcom,ipq9574-imem
> +        - qcom,ipq5332-imem
>          - qcom,ipq5424-imem

[Severity: Low]
This isn't a bug, but does this addition break the alphabetical sorting of
the compatible string list?

Placing qcom,ipq9574-imem and qcom,ipq5332-imem directly above 
qcom,ipq5424-imem results in ipq9574 appearing before ipq5332 and ipq5424,
which seems to violate the expected alphabetical sort order.

>          - qcom,kaanapali-imem
>          - qcom,maili-imem

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=1

  reply	other threads:[~2026-10-01 15:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 15:11 [PATCH 0/5] Add support for reporting boot status on Qualcomm IPQ9574 and IPQ5332 Kathiravan Thirumoorthy
2026-10-01 15:11 ` [PATCH 1/5] dt-bindings: sram: Document IMEM found in Qualcomm's " Kathiravan Thirumoorthy
2026-10-01 15:18   ` sashiko-bot [this message]
2026-10-02  9:41   ` Krzysztof Kozlowski
2026-10-02 13:03     ` Kathiravan Thirumoorthy
2026-10-01 15:11 ` [PATCH 2/5] arm64: dts: qcom: ipq9574: add the IMEM node Kathiravan Thirumoorthy
2026-10-01 15:11 ` [PATCH 3/5] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2026-10-01 15:20   ` sashiko-bot
2026-10-01 15:11 ` [PATCH 4/5] arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM Kathiravan Thirumoorthy
2026-10-01 15:18   ` sashiko-bot
2026-10-01 15:11 ` [PATCH 5/5] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2026-10-01 15:16   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001151833.6C9C91F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.