From: sashiko-bot@kernel.org
To: "Jeff Barnes" <jeffbarnes@linux.microsoft.com>
Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, Frank.Li@kernel.org
Subject: Re: [PATCH v2] Revert "PCI: layerscape: Change default error response behavior"
Date: Thu, 01 Oct 2026 15:37:40 +0000 [thread overview]
Message-ID: <20261001153741.0CDC61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001153323.1965074-1-jeffbarnes@linux.microsoft.com>
> This reverts commit 84d897d69938
> ("PCI: layerscape: Change default error response behavior").
>
> The Layerscape PCIe driver programs the DesignWare
> AMBA_ERROR_RESPONSE_DEFAULT register at offset 0x8d0 with 0x9401.
>
> For AXI, the documented default with AMBA_ERROR_RESPONSE_GLOBAL cleared
> returns OKAY with all-ones data for errors on non-posted requests.
> Setting AMBA_ERROR_RESPONSE_GLOBAL causes an AXI error response instead,
> with AMBA_ERROR_RESPONSE_MAP selecting SLVERR or DECERR for individual
> PCIe completion errors.
>
> The value 0x9401 sets AMBA_ERROR_RESPONSE_GLOBAL and maps Unsupported
> Request, Completer Abort, and Completion Timeout to SLVERR.
>
> [ ... ]
> failed non-posted PCIe transaction does not become a fatal AXI error.
>
> Fixes: 84d897d69938 ("PCI: layerscape: Change default error response behavior")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jeff Barnes <jeffbarnes@linux.microsoft.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001153323.1965074-1-jeffbarnes@linux.microsoft.com?part=1
next prev parent reply other threads:[~2026-10-01 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 19:43 [PATCH] PCI: layerscape: use default error response behavior jeffbarnes
2026-09-29 19:47 ` sashiko-bot
2026-09-30 16:41 ` Frank Li
2026-09-30 17:02 ` Jeff Barnes
2026-10-01 15:33 ` [PATCH v2] Revert "PCI: layerscape: Change default error response behavior" Jeff Barnes
2026-10-01 15:37 ` sashiko-bot [this message]
2026-10-01 16:30 ` Frank Li
2026-10-01 16:38 ` Frank Li
2026-10-08 13:57 ` Jeff Barnes
2026-10-08 16:42 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001153741.0CDC61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=imx@lists.linux.dev \
--cc=jeffbarnes@linux.microsoft.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.