Re: [PATCH v3 1/2] dt-bindings: input: gpio-keys: add pinctrl states

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: gpio-keys: pinctrl-names constraint breaks at91-kizbox3-hs.dts
--

commit 907856f3f65db782a0530ddca90b6bdcafcea767
Author: Kendall Willis <k-willis@ti.com>

dt-bindings: input: gpio-keys: add pinctrl states

This commit documents pinctrl properties on the gpio-keys device node. It
adds the default pinctrl state and a wakeup state to configure pins for
system suspend if GPIO is a wakeup source.

> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> index cc78c21529213..a0712fba45845 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> @@ -22,6 +22,22 @@ properties:
>  
>    poll-interval: true
>  
> +  pinctrl-0:
> +    description: Default pinctrl state
> +
> +  pinctrl-1:
> +    description: Wakeup pinctrl state
> +
> +  pinctrl-names:
> +    description:
> +      When present should contain at least "default" describing the default pin
> +      states. The "wakeup" state describes the pin state used to wakeup the system
> +      when wakeup is enabled and the system is suspended.
> +    minItems: 1
> +    items:
> +      - const: default
> +      - const: wakeup

[Severity: Medium]
Will this implicit maxItems constraint break validation for existing in-tree
device trees?

Looking at arch/arm/boot/dts/microchip/at91-kizbox3-hs.dts, there is an
existing gpio-keys node that defines 5 items in pinctrl-names:

	gpio-keys {
		compatible = "gpio-keys";
		pinctrl-names = "default" , "default", "default",
				"default", "default";
		pinctrl-0 = <&pinctrl_key_gpio_default>;
		pinctrl-1 = <&pinctrl_pio_rf &pinctrl_pio_wifi>;
		...
	}

Since the schema update limits the items list to exactly two specific
entries ("default" and "wakeup"), this will introduce a make dtbs_check
validation regression for the existing board. Should the schema accommodate
this existing usage, or should the board be updated in the same series?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-upstream-gpio-wakeup-v3-0-6f3bcde367a3@ti.com?part=1