All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: IgorpetinDev <igorpetindev@gmail.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org,
	syzbot+843bf2f48f4d12e6682e@syzkaller.appspotmail.com,
	linux-serial@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCH] serial: core: shut down initialized port on removal
Date: Thu, 1 Oct 2026 10:58:24 +0200	[thread overview]
Message-ID: <2026100116-avenge-reroute-44ab@gregkh> (raw)
In-Reply-To: <CAG21Q81Fc1-0_ZX04tY9TUv61iQi9uYHj2Ew+vQgZjWczKbZ6Q@mail.gmail.com>

On Sat, Sep 26, 2026 at 04:05:31PM +0300, IgorpetinDev wrote:
> Hi Greg,
> Note: syzbot did not actually provide a reproducer for this crash -
> this patch is based on code analysis of the trace, not on hardware
> testing. The pcl812 trigger from syzkaller is synthetic.
> 
> On a console port, tty_port_shutdown() skips ops->shutdown() because
> port->console is true, so the IRQ is never released.
> If the device is later unbound/removed, serial_core_remove_one_port()
> frees uport->name via kfree(), but the IRQ is never freed.
> Result: a stale irqaction pointing at freed memory in action->name,
> even without anything else requesting that IRQ line.
> 
> sashiko-bot also pointed out a data race on port->console = false
> outside the mutex - separate issue, but relevant.
> 
> If the underlying problem looks real to you, I'd rather withdraw this
> patch, put together an actual reproducer (unbind a console port, check
> for the stale irqaction), fix the locking properly, and send a v2.

Please do so, thanks.

greg k-h

  reply	other threads:[~2026-10-01  8:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 19:22 [PATCH] serial: core: shut down initialized port on removal Igor Putko
2026-09-24 19:39 ` sashiko-bot
2026-09-25  5:34 ` Greg Kroah-Hartman
2026-09-26 13:05 ` IgorpetinDev
2026-10-01  8:58   ` Greg KH [this message]
2026-10-03 16:33 ` [PATCH v2] " Igor Putko
2026-10-03 17:56   ` sashiko-bot
2026-10-13 16:45   ` Phil Rosenthal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100116-avenge-reroute-44ab@gregkh \
    --to=greg@kroah.com \
    --cc=igorpetindev@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=syzbot+843bf2f48f4d12e6682e@syzkaller.appspotmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.