All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Birger Koblitz <mail@birger-koblitz.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
	Jianhui Xu <neuromoments@gmail.com>
Subject: Re: [PATCH net-next v14 03/14] ax88179_178a: Fix endianness of pause watermark register
Date: Thu, 1 Oct 2026 18:14:53 -0700	[thread overview]
Message-ID: <20261001181453.23ffac71@kernel.org> (raw)
In-Reply-To: <20260929-ax88179a-v14-3-a1f2249e42ea@birger-koblitz.de>

On Tue, 29 Sep 2026 05:18:51 +0200 Birger Koblitz wrote:
> The 16-bit pause watermark register is little endian as
> described in the ASIX 4.1.0 out-of-tree driver. Correct the
> register byte sequence but also swap the configuration values
> used in the code in order to keep the current behaviour.
> 
> The endianness is relevant for 16-bit writes to the register.
> 
> Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  drivers/net/usb/ax88179_178a.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index 81d8412ce8e2fac981df076ea1385e6e87525cfe..2ed46ab62c0065d32040439f31d44f118d7e9952 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -32,8 +32,8 @@
>  #define AX_ACCESS_EEPROM			0x04
>  #define AX_ACCESS_EFUS				0x05
>  #define AX_RELOAD_EEPROM_EFUSE			0x06
> -#define AX_PAUSE_WATERLVL_HIGH			0x54
> -#define AX_PAUSE_WATERLVL_LOW			0x55
> +#define AX_PAUSE_WATERLVL_LOW			0x54
> +#define AX_PAUSE_WATERLVL_HIGH			0x55
>  
>  #define PHYSICAL_LINK_STATUS			0x02
>  	#define	AX_USB_SS		0x04
> @@ -1619,11 +1619,10 @@ static int ax88179_reset(struct usbnet *dev)
>  	dev->rx_urb_size = 1024 * 20;
>  
>  	*tmp = 0x34;
> -	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp);
> +	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 1, tmp);
>  
>  	*tmp = 0x52;
> -	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH,
> -			  1, 1, tmp);
> +	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 1, tmp);
>  
>  	/* Enable checksum offload */
>  	*tmp = AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
> 

Looks like I already applied this as commit a4e22e9253e7ed ?
Please rebase on latest net-next it should drop you, and then repost

  reply	other threads:[~2026-10-02  1:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  3:18 [PATCH net-next v14 00/14] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 01/14] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 02/14] phylib: Add support for PHYs with broken forced mode Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 03/14] ax88179_178a: Fix endianness of pause watermark register Birger Koblitz
2026-10-02  1:14   ` Jakub Kicinski [this message]
2026-10-02  4:49     ` Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 04/14] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 05/14] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 06/14] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 07/14] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 08/14] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 09/14] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 10/14] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-09-29  3:18 ` [PATCH net-next v14 11/14] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-09-29  3:19 ` [PATCH net-next v14 12/14] ax88179_178a: Update driver name and information Birger Koblitz
2026-09-29  3:19 ` [PATCH net-next v14 13/14] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-09-29  3:19 ` [PATCH net-next v14 14/14] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001181453.23ffac71@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=chenhuacai@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=loongarch@lists.linux.dev \
    --cc=mail@birger-koblitz.de \
    --cc=netdev@vger.kernel.org \
    --cc=neuromoments@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.