All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matthew Lavine <matt@matthewlavine.net>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: octeon: correct parameter alignment
Date: Thu, 1 Oct 2026 07:33:50 +0200	[thread overview]
Message-ID: <2026100129-acrobat-rudder-6bc3@gregkh> (raw)
In-Reply-To: <20260912145143.186527-1-matt@matthewlavine.net>

On Sat, Sep 12, 2026 at 10:51:26AM -0400, Matthew Lavine wrote:
> Correct parameter alignment in cvmx_pko_send_packet_finish() while
> abiding by the column limit
> 
> This addresses the "Alignment should match open parenthesis" check
> reported by checkpatch.pl
> 
> Signed-off-by: Matthew Lavine <matt@matthewlavine.net>
> ---
>  drivers/staging/octeon/octeon-stubs.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 9c1968b7e2d1..935ce6495f3b 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1386,9 +1386,9 @@ static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue,
>  						enum cvmx_pko_lock use_locking)
>  { }
>  
> -static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(u64 port,
> -		u64 queue, union cvmx_pko_command_word0 pko_command,
> -		union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
> +static inline enum cvmx_pko_status
> +cvmx_pko_send_packet_finish(u64 port, u64 queue, union cvmx_pko_command_word0 pko_command,
> +			    union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
>  {
>  	return 0;
>  }
> -- 
> 2.55.0
> 
> 

No, this warning can be igured as the function name and structures just
are "too big".

thanks,

greg k-h

      reply	other threads:[~2026-10-01  5:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 14:51 [PATCH] staging: octeon: correct parameter alignment Matthew Lavine
2026-10-01  5:33 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100129-acrobat-rudder-6bc3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=matt@matthewlavine.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.