Re: [PATCH 2/2] tools: perf: flamegraph.py: fix "Error reading report header"

[sashiko-bot@kernel.org]

> When running "perf script flamegraph" in a directory without perf.data,
> the script succeeds but prints out the following error:
> 
>     # perf script flamegraph -ag -F999 -- sleep 5
>     failed to open perf.data: No such file or directory  (try 'perf record' first)
>     Error reading report header: Command '['perf', 'report', '--header-only']' returned non-zero exit status 255.
>     dumping data to flamegraph.html
> 
> If a "perf.data" file were present in the working directory, then the
> error would not occur, but flamegraph.py would silently include an
> incorrect header as the context for the flamegraph.
> 
> The issue is with the "-i" option and how it interacts with option
> parsing in the flamegraph-report shell script. Below are the different
> flamegraph-report script calls in recent git history:
> [ ... ]
> what input file perf is processing. The previous commit implements a
> helper for this, so drop the "-i" option entirely and use the helper to
> properly detect the filename.
> 
> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001182004.1160406-1-stephen.s.brennan@oracle.com?part=2